[jira] [Commented] (AIRFLOW-5580) Add base class for system test

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942184#comment-16942184 ] 

ASF GitHub Bot commented on AIRFLOW-5580:
-----------------------------------------

nuclearpinguin commented on pull request #6229: [AIRFLOW-5580] Add base class for system test
URL: https://github.com/apache/airflow/pull/6229
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5580
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   This PR proposes base class for running system test in Airflow. The
   main concepts is to create an example DAG and run it for test purpose. This
   is especially important in case of integration with third party services. The change is a part of refactor of GCP system test and aims to decouple running a test and handling authentication. 
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add base class for system test
> ------------------------------
>
>                 Key: AIRFLOW-5580
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5580
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 2.0.0
>            Reporter: Tomasz Urbaszek
>            Priority: Major
>
> It would be great to have system test in Airflow. This could be especially useful for testing integrations with third party providers. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)