[jira] [Updated] (SAMZA-361) Remove Grizzled SLF4J

["Yan Fang (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SAMZA-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yan Fang updated SAMZA-361:
---------------------------

    Attachment: SAMZA-361.patch

RB: https://reviews.apache.org/r/24917/

* Basically, refer to the [kafka logging class|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/utils/Logging.scala] and [grizziled logging class|https://github.com/bmc/grizzled-slf4j/blob/master/src/main/scala/grizzled/slf4j/slf4j.scala].
* Also added MDC methods to put/get/remove/clear.
* Tested in local.

Thank you.

> Remove Grizzled SLF4J
> ---------------------
>
>                 Key: SAMZA-361
>                 URL: https://issues.apache.org/jira/browse/SAMZA-361
>             Project: Samza
>          Issue Type: Bug
>          Components: container
>    Affects Versions: 0.8.0
>            Reporter: Chris Riccomini
>            Assignee: Yan Fang
>             Fix For: 0.8.0
>
>         Attachments: SAMZA-361.patch
>
>
> The cons of Grizzled SLF4J outweigh the pros. We can [create a single class|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/utils/Logging.scala] that does what we need for logging. Eliminating the Grizzled dependency means that we'll have one less Scala binary to depend on. It will also give us more control over SLF4J APis that we might want to use (e.g. the [MDC|http://www.slf4j.org/api/org/slf4j/MDC.html], see SAMZA-310).



--
This message was sent by Atlassian JIRA
(v6.2#6252)