[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #1374: Add max background jobs to configuration

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #1374:
URL: https://github.com/apache/incubator-kvrocks/pull/1374#discussion_r1161113262


##########
kvrocks.conf:
##########
@@ -587,15 +587,19 @@ rocksdb.target_file_size_base 128
 # allowed.
 rocksdb.max_write_buffer_number 4
 
-# Maximum number of concurrent background compaction jobs, submitted to
+# Maximum number of concurrent background jobs (compactions and flushes).
+# RocksDB automatically decides this based on the  value of max_background_jobs. For backwards compatibility we will set `max_background_jobs = max_background_compactions + max_background_flushes` in the case where user sets at least one of `max_background_compactions` or `max_background_flushes` (we replace -1 by 1 in case one option is unset).

Review Comment:
   Seems it is better to split this comment to multiple lines like all other comments in this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org