You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2011/01/03 20:27:45 UTC
[jira] Created: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
[HBase] Rename options to newer non-whirr prefix style
------------------------------------------------------
Key: WHIRR-188
URL: https://issues.apache.org/jira/browse/WHIRR-188
Project: Whirr
Issue Type: Improvement
Components: service/hbase
Affects Versions: 0.3.0
Reporter: Lars George
Assignee: Lars George
Priority: Trivial
Fix For: 0.3.0
I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981715#action_12981715 ]
Lars George commented on WHIRR-188:
-----------------------------------
I would say yes, initially I was going to say no but that mixture of "--option" and "-Doption" is seemingly random and confuses people. I would prefer that any available option has its proper prefix and can be used on the command line for every service and basic Whirr option.
It could mean the need to add some prefix for a service or add a prefix for the basic options. So either "--whirr.instance-template" or leave them and add the service prefix like "--hbase.resterver.port"?
Asking for opinions here.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977381#action_12977381 ]
Tom White commented on WHIRR-188:
---------------------------------
> Is it "hbase" for Apache HBase or "apache-hbase" since there might be also a "cdh-hbase"? Or even "hbase" for shared and the others for specific services?
I think it should be "hbase" since we use "whirr.hbase-install-runurl" (or, better, "whirr.hbase.install-runurl") to control which HBase to install.
> Should we use "whirr.hbase-configure-runurl" or "whirr.hbase.configure-runurl" or even (see above) "whirr.apache-hbase.configure-runurl"?
"whirr.hbase.configure-runurl" is probably best. "whirr.hadoop-install-runurl" and "whirr.hadoop-configure-runurl" don't conform to this, so perhaps we should deprecate these.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976967#action_12976967 ]
Tom White commented on WHIRR-188:
---------------------------------
Hadoop uses "whirr.hadoop-install-runurl" and "whirr.hadoop-configure-runurl" - shouldn't we keep the equivalent for HBase? (I.e. leave it as it is now.)
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-188:
------------------------------
Status: Patch Available (was: Open)
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated WHIRR-188:
----------------------------
Fix Version/s: (was: 0.3.0)
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981724#action_12981724 ]
Andrei Savu commented on WHIRR-188:
-----------------------------------
I understand. I vote for keeping the existing ones the way they are (whirr specific options) and for adding a service prefix like {{--hbase.restserver.port}} for service / role specific options. I find this to be intuitive enough.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981727#action_12981727 ]
Lars George commented on WHIRR-188:
-----------------------------------
+1, good for me.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981522#action_12981522 ]
Tom White commented on WHIRR-188:
---------------------------------
Lars made a related point (offline) that if "--instance-template" maps to "whirr.instance-template",
then there's no way to use e.g. "--hbase.restserver.port". We need to have something like "-D hbase.restserver.port=10000" or similar. Or is there a better way of doing this?
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981873#action_12981873 ]
Tom White commented on WHIRR-188:
---------------------------------
Agreed. We should probably do this in another JIRA.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981525#action_12981525 ]
Andrei Savu commented on WHIRR-188:
-----------------------------------
Do we really need to support all the configuration options as command line arguments?
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981853#action_12981853 ]
Tom White commented on WHIRR-188:
---------------------------------
This sounds good. We still need a way for the CLI to get all the (Whirr) options for a particular service so it can set up the options parser.
I think we still need to add a -D option for service options (like the ones being introduced in WHIRR-55). We don't want to have to track them all in Whirr obviously, and there are lots of them so it would make help output unusable if they were regular options.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977170#action_12977170 ]
Lars George commented on WHIRR-188:
-----------------------------------
Tom and I discussed this offline and it seems that the greater plan is to have options that are passed on to a service are prefixed with the service. Those options that are handled by the ClusterActions are prefixed with "whirr" since they are handled by the base framework directly.
Questions:
* Is it "hbase" for Apache HBase or "apache-hbase" since there might be also a "cdh-hbase"? Or even "hbase" for shared and the others for specific services?
* Should we use "whirr.hbase-configure-runurl" or "whirr.hbase.configure-runurl" or even (see above) "whirr.apache-hbase.configure-runurl"?
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981867#action_12981867 ]
Lars George commented on WHIRR-188:
-----------------------------------
I agree it makes no sense to have everything exposed. No other project does that once you get to a certain size.
Yeah, a mechanism where a service can register sounds like a good idea.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-188:
------------------------------
Status: Open (was: Patch Available)
Needs more discussions and setting rules.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981935#action_12981935 ]
Andrei Savu commented on WHIRR-188:
-----------------------------------
Exposing only a subset makes perfect sense and should keep things manageable. I like it.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-188) [HBase] Rename options to newer
non-whirr prefix style
Posted by "Lars George (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars George updated WHIRR-188:
------------------------------
Attachment: WHIRR-188.patch
Renames the property keys to reflect the service association.
> [HBase] Rename options to newer non-whirr prefix style
> ------------------------------------------------------
>
> Key: WHIRR-188
> URL: https://issues.apache.org/jira/browse/WHIRR-188
> Project: Whirr
> Issue Type: Improvement
> Components: service/hbase
> Affects Versions: 0.3.0
> Reporter: Lars George
> Assignee: Lars George
> Priority: Trivial
> Fix For: 0.3.0
>
> Attachments: WHIRR-188.patch
>
>
> I started this in WHIRR-25 with the Avro/Rest/Thrift servers. This cleans up the others too.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.