You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/14 11:05:05 UTC
[GitHub] [shardingsphere] zengzhihong opened a new pull request #6032: Use YAML file instead of inline string in test cases in OrchestrationSpringBootRegistryShardingTest.java #5428
zengzhihong opened a new pull request #6032:
URL: https://github.com/apache/shardingsphere/pull/6032
…SpringBootRegistryShardingTest.java #5428
Fixes #5428.
Changes proposed in this pull request:
- create sharding-databases.yaml and sharding-rule.yaml on resource/yaml directory
- added private static method readYAML to read these files into string instead of inline string in test cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #6032: Use YAML file instead of inline string in test cases in OrchestrationSpringBootRegistryShardingTest.java #5428
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #6032:
URL: https://github.com/apache/shardingsphere/pull/6032
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #6032: Use YAML file instead of inline string in test cases in OrchestrationSpringBootRegistryShardingTest.java #5428
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #6032:
URL: https://github.com/apache/shardingsphere/pull/6032#issuecomment-643753747
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6032?src=pr&el=h1) Report
> Merging [#6032](https://codecov.io/gh/apache/shardingsphere/pull/6032?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ad6c97b5ff97c7ed37cece0ef40f1c53dc504a5e&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/6032?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6032 +/- ##
=========================================
Coverage 53.10% 53.10%
Complexity 438 438
=========================================
Files 1195 1195
Lines 20957 20957
Branches 3770 3770
=========================================
Hits 11129 11129
Misses 9132 9132
Partials 696 696
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6032?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/6032?src=pr&el=footer). Last update [ad6c97b...92dff18](https://codecov.io/gh/apache/shardingsphere/pull/6032?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org