You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Eric Lin <er...@cloudera.com> on 2017/07/03 05:36:36 UTC
Re: Review Request 57551: SQOOP-2272 - Import decimal columns from
mysql to hive 0.14
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57551/
-----------------------------------------------------------
(Updated July 3, 2017, 5:36 a.m.)
Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
Changes
-------
Uploading new patch based on latest trunk code for review. Please help to have a look and hopefully resolve the JIRA. Thanks a lot for your help.
Repository: sqoop-trunk
Description
-------
Currently Sqoop converts DECIMAL from RDMS into DOUBLE in Hive, which is not correct as user will lose precisions. Since Hive supports DECIMAL long ago, we should support DECIMAL to DECIMAL conversion from Sqoop to Hive.
Diffs (updated)
-----
src/java/org/apache/sqoop/hive/HiveTypes.java ad00535
src/java/org/apache/sqoop/hive/TableDefWriter.java deec32d
src/test/com/cloudera/sqoop/hive/TestHiveImport.java a624f52
src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java dbf0dde
testdata/hive/scripts/decimalImport.q PRE-CREATION
Diff: https://reviews.apache.org/r/57551/diff/6/
Changes: https://reviews.apache.org/r/57551/diff/5-6/
Testing
-------
Test case + maunaul test
Thanks,
Eric Lin
Re: Review Request 57551: SQOOP-2272 - Import decimal columns from
mysql to hive 0.14
Posted by Eric Lin via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57551/
-----------------------------------------------------------
(Updated July 13, 2018, 8:06 a.m.)
Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
Changes
-------
adde bug link
Bugs: SQOOP-2272
https://issues.apache.org/jira/browse/SQOOP-2272
Repository: sqoop-trunk
Description
-------
Currently Sqoop converts DECIMAL from RDMS into DOUBLE in Hive, which is not correct as user will lose precisions. Since Hive supports DECIMAL long ago, we should support DECIMAL to DECIMAL conversion from Sqoop to Hive.
Diffs
-----
src/java/org/apache/sqoop/hive/HiveTypes.java ad00535
src/java/org/apache/sqoop/hive/TableDefWriter.java deec32d
src/test/com/cloudera/sqoop/hive/TestHiveImport.java a624f52
src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java dbf0dde
testdata/hive/scripts/decimalImport.q PRE-CREATION
Diff: https://reviews.apache.org/r/57551/diff/6/
Testing
-------
Test case + maunaul test
Thanks,
Eric Lin
Re: Review Request 57551: SQOOP-2272 - Import decimal columns from
mysql to hive 0.14
Posted by Sandish Kumar HN <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57551/#review186055
-----------------------------------------------------------
All test's passed.
- Sandish Kumar HN
On July 3, 2017, 5:36 a.m., Eric Lin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57551/
> -----------------------------------------------------------
>
> (Updated July 3, 2017, 5:36 a.m.)
>
>
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Currently Sqoop converts DECIMAL from RDMS into DOUBLE in Hive, which is not correct as user will lose precisions. Since Hive supports DECIMAL long ago, we should support DECIMAL to DECIMAL conversion from Sqoop to Hive.
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/hive/HiveTypes.java ad00535
> src/java/org/apache/sqoop/hive/TableDefWriter.java deec32d
> src/test/com/cloudera/sqoop/hive/TestHiveImport.java a624f52
> src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java dbf0dde
> testdata/hive/scripts/decimalImport.q PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/57551/diff/6/
>
>
> Testing
> -------
>
> Test case + maunaul test
>
>
> Thanks,
>
> Eric Lin
>
>