You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/04/13 17:11:07 UTC

[GitHub] [helix] dasahcc commented on a change in pull request #1696: Change participant message monitor from static metric to dynamic metric

dasahcc commented on a change in pull request #1696:
URL: https://github.com/apache/helix/pull/1696#discussion_r612631228



##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ParticipantMessageMonitor.java
##########
@@ -19,10 +19,27 @@
  * under the License.
  */
 
-public class ParticipantMessageMonitor implements ParticipantMessageMonitorMBean {
-  public static final String PARTICIPANT_KEY = "ParticipantName";
+import java.util.ArrayList;
+import java.util.List;

Review comment:
       Question: was this formatted? If yes, then our formatter has problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org