You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2021/09/08 13:42:52 UTC

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds 

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17835


Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................

IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds

test_iceberg.py::test_time_travel sets the TIMEZONE query option
during execution. In the end it sets the TIMEZONE to 'Asia/Tokyo'.

The problem is that it sets the TIMEZONE of the client of the
ImpalaTestSuite. This means that a subsequent test will use
timezone 'Asia/Tokyo' instead of the local one.

This patch fixes this issue by creating a local Impala client for
the test.

Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
---
M tests/query_test/test_iceberg.py
1 file changed, 15 insertions(+), 11 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/17835/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 1:

(1 comment)

Thanks for the comment!

http://gerrit.cloudera.org:8080/#/c/17835/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/17835/1/tests/query_test/test_iceberg.py@124
PS1, Line 124: create_impala_client
> Other tests I saw also call .close() on the clients created with create_imp
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Sep 2021 16:35:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 14:18:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9438/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Sep 2021 14:07:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................

IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds

test_iceberg.py::test_time_travel sets the TIMEZONE query option
during execution. In the end it sets the TIMEZONE to 'Asia/Tokyo'.

The problem is that it sets the TIMEZONE of the client of the
ImpalaTestSuite. This means that a subsequent test will use
timezone 'Asia/Tokyo' instead of the local one.

This patch fixes this issue by creating a local Impala client for
the test.

Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Reviewed-on: http://gerrit.cloudera.org:8080/17835
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_connection.py
M tests/query_test/test_iceberg.py
2 files changed, 90 insertions(+), 80 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17835/1/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/17835/1/tests/query_test/test_iceberg.py@124
PS1, Line 124: create_impala_client
Other tests I saw also call .close() on the clients created with create_impala_client().

Currently we can't use a "with" block for this - some pointers if you want to implement it :)
https://stackoverflow.com/questions/865115/how-do-i-correctly-clean-up-a-python-object



-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Sep 2021 18:03:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Sep 2021 18:57:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7465/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 08:07:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17835

to look at the new patch set (#2).

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................

IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds

test_iceberg.py::test_time_travel sets the TIMEZONE query option
during execution. In the end it sets the TIMEZONE to 'Asia/Tokyo'.

The problem is that it sets the TIMEZONE of the client of the
ImpalaTestSuite. This means that a subsequent test will use
timezone 'Asia/Tokyo' instead of the local one.

This patch fixes this issue by creating a local Impala client for
the test.

Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
---
M tests/common/impala_connection.py
M tests/query_test/test_iceberg.py
2 files changed, 90 insertions(+), 80 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/17835/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Sep 2021 08:07:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9443/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Sep 2021 16:59:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10905: test iceberg.py test time travel fails in exhaustive builds

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17835 )

Change subject: IMPALA-10905: test_iceberg.py test_time_travel fails in exhaustive builds
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17835/2/tests/query_test/test_iceberg.py
File tests/query_test/test_iceberg.py:

http://gerrit.cloudera.org:8080/#/c/17835/2/tests/query_test/test_iceberg.py@165
PS2, Line 165: )
flake8: E501 line too long (91 > 90 characters)



-- 
To view, visit http://gerrit.cloudera.org:8080/17835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c172df865bc35dd1792146f4045fbc16e04d116
Gerrit-Change-Number: 17835
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Sep 2021 16:35:29 +0000
Gerrit-HasComments: Yes