[jira] [Comment Edited] (FLINK-23154) Fix Python PackagedProgramRetrieverImplTest implementations

["Nicholas Jiang (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-23154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369291#comment-17369291 ] 

Nicholas Jiang edited comment on FLINK-23154 at 6/25/21, 7:09 AM:
------------------------------------------------------------------

[~mapohl], according to previous experience for adding PythonPackagedProgramRetrieverImplTest, there is no good solution to set PyFlink folder in flink-clients module. But IMO, this could be added to the tests of flink-python module, which module could set up the flink python opt folder.
[~dianfu], what do you think about?


was (Author: nicholasjiang):
[~mapohl], According to previous experience for adding PythonPackagedProgramRetrieverImplTest, there is no good solution to set PyFlink folder in flink-clients module. But IMO, this could be added to the tests of flink-python module, which module could set up the flink python opt folder.
[~dianfu], what do you think about?

> Fix Python PackagedProgramRetrieverImplTest implementations
> -----------------------------------------------------------
>
>                 Key: FLINK-23154
>                 URL: https://issues.apache.org/jira/browse/FLINK-23154
>             Project: Flink
>          Issue Type: Bug
>          Components: API / Python
>            Reporter: Matthias
>            Priority: Major
>
> We refactored the {{PackagedProgramRetriever}} class hierarchy as part of FLINK-21445. As part of this, I added some tests for the Python path but didn't look to deep into how to set up the flink python opt folder within the test infrastructure. Instead, I added {{Assume}} calls.
> This ticket is about removing these {{Assume}} calls and implementing the tests properly.
> It affects testss in {{FromJarEntryClassInformationProviderTest}} and {{PackagedProgramRetrieverImplTest}}.
> --
> The corresponding code changes are still subject to change and are currently under review in a [draft PR for FLINK-21445|https://github.com/apache/flink/pull/16286].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)