You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by "wangxianghu (Jira)" <ji...@apache.org> on 2020/06/23 12:54:00 UTC

[jira] [Issue Comment Deleted] (HUDI-1035) Remove unused class KeyLookupResult

     [ https://issues.apache.org/jira/browse/HUDI-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

wangxianghu updated HUDI-1035:
------------------------------
    Comment: was deleted

(was: [~vinoth] I have checked throughout the hudi-spark module, no reflection used it.

and just as its Javadoc says, it is just an encapsulation of query results from a key. 

besides, both these two classes have the same Javadoc description and only No.2 was used in bloom index.

so it is safe to remove.

cc [~yanghua] 

 )

> Remove unused class KeyLookupResult
> -----------------------------------
>
>                 Key: HUDI-1035
>                 URL: https://issues.apache.org/jira/browse/HUDI-1035
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: Code Cleanup
>            Reporter: wangxianghu
>            Assignee: wangxianghu
>            Priority: Minor
>              Labels: pull-request-available
>
> when refactoring hudi-client module, I found there are two KeyLookupResult classes, which are almost the same:
> No.1 -  org.apache.hudi.index.bloom.KeyLookupResult  *(not used anywhere)*
> No.2 - org.apache.hudi.io.HoodieKeyLookupHandle.KeyLookupResult  *(using currently)*
> maybe we should delete the No.1, or replace No.2 with No.1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)