You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "kaxil (via GitHub)" <gi...@apache.org> on 2025/05/23 22:33:37 UTC
[PR] Fix lingering task supervisors when ``EOF`` is missed [airflow]
kaxil opened a new pull request, #51020:
URL: https://github.com/apache/airflow/pull/51020
closes https://github.com/apache/airflow/issues/50500
Adds a new safeguard for cases where the task subprocess closes before all pipe sockets send EOF.
The supervisor now records the
process exit time and forcibly closes any sockets still open after `workers.task_supervisor_socket_cleanup_delay`. This stops the supervisor loop from hanging indefinitely and allows the process to exit cleanly.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lingering task supervisors when ``EOF`` is missed [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #51020:
URL: https://github.com/apache/airflow/pull/51020#issuecomment-2907759453
I have managed to reproduce the bug - not consistently but enough that I can debug this further
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lingering task supervisors when ``EOF`` is missed [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #51020:
URL: https://github.com/apache/airflow/pull/51020#issuecomment-2906587300
I don't love this - it "shouldn't" get in this state, and something might be missed as a result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lingering task supervisors when ``EOF`` is missed [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #51020:
URL: https://github.com/apache/airflow/pull/51020#issuecomment-2906710601
> > I don't love this - it "shouldn't" get in this state, and something might be missed as a result
>
> True, I was being conservative here but I have a different lead too. Verifying 🕐
That being said, while I don't love this either, it might not be a bad safeguard since it checks for the `exit_code`. Which should only be set when task process exits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lingering task supervisors when ``EOF`` is missed [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #51020:
URL: https://github.com/apache/airflow/pull/51020#issuecomment-2906667495
> I don't love this - it "shouldn't" get in this state, and something might be missed as a result
True, I have a different lead too. Verifying 🕐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix lingering task supervisors when ``EOF`` is missed [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil closed pull request #51020: Fix lingering task supervisors when ``EOF`` is missed
URL: https://github.com/apache/airflow/pull/51020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org