You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by rookalkar <gi...@git.apache.org> on 2015/09/24 11:57:52 UTC
[GitHub] incubator-zeppelin pull request: Adding Boxplot
GitHub user rookalkar opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/321
Adding Boxplot
This feature adds a BoxPlot. It works seamlessly for about 10,000 rows of data.
I am currently also working on crunching the data required in the back end and pushing it to front end which will then render the chart.
<img width="833" alt="screen shot 2015-09-21 at 11 22 52 am" src="https://cloud.githubusercontent.com/assets/9201336/10070548/c9523f80-62d0-11e5-9510-39ad27303187.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rookalkar/incubator-zeppelin rookalkar-patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #321
----
commit e63dae83c400496ff640d342d1a211af0a1f9654
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-08T10:41:05Z
Update paragraph.html
add button for donut chart
commit 693632bcf9ba9fbadfbbf0e5134008f00a2685b4
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-08T10:43:40Z
Update paragraph.controller.js
commit f8af320b04d70e2c9e314eeca0ef7705be9a81b8
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-14T10:40:41Z
Update nvd3 version
commit 2df76780519238299fb4e6cdc5a79ef5b305e16e
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-14T10:45:46Z
Update paragraph.html
commit 5d00f5ed6c8eab92964962def5ea11d466b93eef
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-14T10:49:51Z
Update paragraph.controller.js
commit b3bb1c55b871aec80ffcbcbd1440b39ea2e248f2
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-16T07:32:01Z
added calculation of boxplot values
calculates Q1,Q2,Q3,min,max,outliers
commit b02d8503c7001a9cd25a24455179f6477fa230e2
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-16T07:38:46Z
Update paragraph.controller.js
commit 3f0c65771d1d7e0bafe253fd90aad95a6c1edb63
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-22T11:06:44Z
Update paragraph.html
commit edeadbb3da76a78615c65abfe5f1be419bb15b98
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-22T11:13:33Z
Update paragraph.controller.js
commit 3c2a0e7c7a78fb106ac1bfa3cc2db0f796222639
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-23T06:25:07Z
Update paragraph.controller.js
Used map and filter to make style more imperative.
commit e3072e33ec766b8f3a185683df64f503f7483abb
Author: Ruchi Ookalkar <ro...@gmail.com>
Date: 2015-09-23T06:28:16Z
Update paragraph.controller.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Adding Boxplot
Posted by AntoineAugusti <gi...@git.apache.org>.
Github user AntoineAugusti commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/321#issuecomment-144715001
I want to try this locally but so far I haven't been able to do it.
I've pulled your branch and run `mvn package` in the `zeppelin-web` folder, after disabling the linting task in Grunt to let the build success. But even after restarting Zeppelin with `bin/zeppelin-daemon.sh restart`, nothing is showing up in the web UI. Am I missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Adding Boxplot
Posted by deepujain <gi...@git.apache.org>.
Github user deepujain commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/321#issuecomment-144600165
1. Please explain what kind of data will render this plot.
2. Please explain the code changes (code documentation) so it will enable other graph support seamlessly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Adding Boxplot
Posted by deepujain <gi...@git.apache.org>.
Github user deepujain commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/321#issuecomment-145257249
Ruchi,
Could you take time to respond to other queries as well. Also am looking to add support for candle stick and unable to get a dev setup to test changes (like console.log and static candle stick code). Appreciate if you can spare time. (@deepujain) on gmail dot com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-zeppelin pull request: Adding Boxplot
Posted by madhuka udantha <ma...@gmail.com>.
This jshints need to be fixed
It will be not hard as jshint explain the error well with resolve.
On Thu, Oct 1, 2015 at 9:41 AM, deepujain <gi...@git.apache.org> wrote:
> Github user deepujain commented on the pull request:
>
>
> https://github.com/apache/incubator-zeppelin/pull/321#issuecomment-144614817
>
> I see build errors with this patch.
>
> [INFO] Running "jshint:all" (jshint) task
> [INFO]
> [INFO] src/app/notebook/paragraph/paragraph.controller.js
> [INFO] line 724 col 0 Identifier 'col_name' is not in camel case.
> [INFO] line 725 col 0 Identifier 'box_column' is not in camel
> case.
> [INFO] line 725 col 0 Identifier 'col_name' is not in camel case.
> [INFO] line 846 col 4 Missing semicolon.
> [INFO] line 941 col 30 'pivotDataToBoxFormat' was used before it
> was defined.
> [INFO] line 943 col 0 Identifier 'col_index' is not in camel case.
> [INFO] line 945 col 0 Identifier 'box_column' is not in camel
> case.
> [INFO] line 945 col 0 Identifier 'col_index' is not in camel case.
> [INFO] line 945 col 28 Expected '!==' and instead saw '!='.
> [INFO] line 947 col 0 Identifier 'col_index' is not in camel case.
> [INFO] line 950 col 0 Identifier 'col_index' is not in camel case.
> [INFO] line 955 col 0 Identifier 'col_index' is not in camel case.
> [INFO] line 963 col 0 Identifier 'whisker_high' is not in camel
> case.
> [INFO] line 963 col 0 Identifier 'whisker_low' is not in camel
> case.
> [INFO] line 966 col 49 Expected '===' and instead saw '=='.
> [INFO] line 968 col 50 Expected '===' and instead saw '=='.
> [INFO] line 980 col 0 Identifier 'whisker_low' is not in camel
> case.
> [INFO] line 982 col 0 Identifier 'whisker_high' is not in camel
> case.
> [INFO] line 988 col 0 Identifier 'whisker_low' is not in camel
> case.
> [INFO] line 988 col 0 Identifier 'whisker_low' is not in camel
> case.
> [INFO] line 989 col 0 Identifier 'whisker_high' is not in camel
> case.
> [INFO] line 989 col 0 Identifier 'whisker_high' is not in camel
> case.
> [INFO] line 996 col 34 Expected '===' and instead saw '=='.
> [INFO] line 998 col 6 Missing semicolon.
> [INFO] line 725 col 5 'box_column' is not defined.
> [INFO] line 945 col 15 'box_column' is not defined.
> [INFO] line 983 col 34 'secondHalfOfArrr' is not defined.
> [INFO]
> [INFO] ✖ 27 problems
> [INFO]
> [INFO] Warning: Task "jshint:all" failed. Use --force to continue.
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Cheers,
Madhuka Udantha
http://madhukaudantha.blogspot.com
[GitHub] incubator-zeppelin pull request: Adding Boxplot
Posted by deepujain <gi...@git.apache.org>.
Github user deepujain commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/321#issuecomment-144614817
I see build errors with this patch.
[INFO] Running "jshint:all" (jshint) task
[INFO]
[INFO] src/app/notebook/paragraph/paragraph.controller.js
[INFO] line 724 col 0 Identifier 'col_name' is not in camel case.
[INFO] line 725 col 0 Identifier 'box_column' is not in camel case.
[INFO] line 725 col 0 Identifier 'col_name' is not in camel case.
[INFO] line 846 col 4 Missing semicolon.
[INFO] line 941 col 30 'pivotDataToBoxFormat' was used before it was defined.
[INFO] line 943 col 0 Identifier 'col_index' is not in camel case.
[INFO] line 945 col 0 Identifier 'box_column' is not in camel case.
[INFO] line 945 col 0 Identifier 'col_index' is not in camel case.
[INFO] line 945 col 28 Expected '!==' and instead saw '!='.
[INFO] line 947 col 0 Identifier 'col_index' is not in camel case.
[INFO] line 950 col 0 Identifier 'col_index' is not in camel case.
[INFO] line 955 col 0 Identifier 'col_index' is not in camel case.
[INFO] line 963 col 0 Identifier 'whisker_high' is not in camel case.
[INFO] line 963 col 0 Identifier 'whisker_low' is not in camel case.
[INFO] line 966 col 49 Expected '===' and instead saw '=='.
[INFO] line 968 col 50 Expected '===' and instead saw '=='.
[INFO] line 980 col 0 Identifier 'whisker_low' is not in camel case.
[INFO] line 982 col 0 Identifier 'whisker_high' is not in camel case.
[INFO] line 988 col 0 Identifier 'whisker_low' is not in camel case.
[INFO] line 988 col 0 Identifier 'whisker_low' is not in camel case.
[INFO] line 989 col 0 Identifier 'whisker_high' is not in camel case.
[INFO] line 989 col 0 Identifier 'whisker_high' is not in camel case.
[INFO] line 996 col 34 Expected '===' and instead saw '=='.
[INFO] line 998 col 6 Missing semicolon.
[INFO] line 725 col 5 'box_column' is not defined.
[INFO] line 945 col 15 'box_column' is not defined.
[INFO] line 983 col 34 'secondHalfOfArrr' is not defined.
[INFO]
[INFO] ✖ 27 problems
[INFO]
[INFO] Warning: Task "jshint:all" failed. Use --force to continue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Adding Boxplot
Posted by rookalkar <gi...@git.apache.org>.
Github user rookalkar commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/321#issuecomment-145215358
Hi,
Apologies for the delayed response.
As the BoxPlot model was unavailable for nvd3 version 1.5.1-beta which was
being used, I updated it to version 1.8.1. This has created a d3 conflict
which I'm currently trying to resolve.
However, if you resolve the dependancy conflict manually, it should work.
On 1 October 2015 at 18:11, Antoine Augusti <no...@github.com>
wrote:
> I want to try this locally but so far I haven't been able to do it.
>
> I've pulled your branch and run mvn package in the zeppelin-web folder,
> after disabling the linting task in Grunt to let the build success. But
> even after restarting Zeppelin with bin/zeppelin-daemon.sh restart,
> nothing is showing up in the web UI. Am I missing something?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/321#issuecomment-144715001>
> .
>
--
Regards,
Ruchi Ookalkar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---