You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by jo...@gmail.com on 2009/03/27 22:33:50 UTC
Make default view names for OS containers upper-cased
Reviewers: shindig.remailer,
Description:
Changes the canonical name of OpenSocial views, in the default container
config, to upper-cased versions of themselves. Aliases using lower-cased
names are provided.
This makes it possible for an OpenSocial app rendered using Shindig to
retrieve (in JS) its current view and meaningfully compare the resulting
name (without modification to gadgets.views.ViewType values, all of
which are capitalized.
Please review this at http://codereview.appspot.com/28128
Affected files:
container.js
Index: container.js
===================================================================
--- container.js (revision 759009)
+++ container.js (working copy)
@@ -97,15 +97,15 @@
"jsonProxyUrl" : "http://%host%/gadgets/makeRequest"
},
"views" : {
- "profile" : {
+ "PROFILE" : {
"isOnlyVisible" : false,
"urlTemplate" : "http://localhost/gadgets/profile?{var}",
- "aliases": ["DASHBOARD", "default"]
+ "aliases": ["DASHBOARD", "profile", "default"]
},
- "canvas" : {
+ "CANVAS" : {
"isOnlyVisible" : true,
"urlTemplate" : "http://localhost/gadgets/canvas?{var}",
- "aliases" : ["FULL_PAGE"]
+ "aliases" : ["FULL_PAGE", "canvas"]
}
},
"rpc" : {
Re: Make default view names for OS containers upper-cased
Posted by John Hjelmstad <fa...@google.com>.
Thanks for your response. I'm happy to toss it, given how long this
situation has existed without much pain. Good find on the old thread btw,
figured this had to have been discussed before.
On Fri, Mar 27, 2009 at 3:37 PM, Adam Winer <aw...@google.com> wrote:
> I'm not so sure that the real problem here isn't the ViewType
> constants. Changing these to uppercase would break any gadgets
> working in Shindig that are calling view.getName() already.
>
> See
> http://markmail.org/message/g4vz66uo2xxjprsp?q=view.getName%28%29+%3D%3D+%27canvas%27&page=1&refer=5zck4n7dm6hiefi5#query:view.getName%28%29%20%3D%3D%20%27canvas%27+page:1+mid:q2q7qzrk2lyjjxy4+state:results
> for an earlier discussion of this issue.
>
> The spec here is just odd, as many of the enums in opensocial have
> lowercased values for the uppercase constants; I don't know why this
> one doesn't, as the overwhelming usage of view names in the wild
> appears to be lowercase, not uppercase.
>
> So, on the whole, I'm extremely ambivalent about making this change.
>
>
> On Fri, Mar 27, 2009 at 2:33 PM, <jo...@gmail.com> wrote:
> > Reviewers: shindig.remailer,
> >
> > Description:
> > Changes the canonical name of OpenSocial views, in the default container
> > config, to upper-cased versions of themselves. Aliases using lower-cased
> > names are provided.
> >
> > This makes it possible for an OpenSocial app rendered using Shindig to
> > retrieve (in JS) its current view and meaningfully compare the resulting
> > name (without modification to gadgets.views.ViewType values, all of
> > which are capitalized.
> >
> > Please review this at http://codereview.appspot.com/28128
> >
> > Affected files:
> > container.js
> >
> >
> > Index: container.js
> > ===================================================================
> > --- container.js (revision 759009)
> > +++ container.js (working copy)
> > @@ -97,15 +97,15 @@
> > "jsonProxyUrl" : "http://%host%/gadgets/makeRequest"
> > },
> > "views" : {
> > - "profile" : {
> > + "PROFILE" : {
> > "isOnlyVisible" : false,
> > "urlTemplate" : "http://localhost/gadgets/profile?{var}",
> > - "aliases": ["DASHBOARD", "default"]
> > + "aliases": ["DASHBOARD", "profile", "default"]
> > },
> > - "canvas" : {
> > + "CANVAS" : {
> > "isOnlyVisible" : true,
> > "urlTemplate" : "http://localhost/gadgets/canvas?{var}",
> > - "aliases" : ["FULL_PAGE"]
> > + "aliases" : ["FULL_PAGE", "canvas"]
> > }
> > },
> > "rpc" : {
> >
> >
> >
>
Re: Make default view names for OS containers upper-cased
Posted by Adam Winer <aw...@google.com>.
I'm not so sure that the real problem here isn't the ViewType
constants. Changing these to uppercase would break any gadgets
working in Shindig that are calling view.getName() already.
See http://markmail.org/message/g4vz66uo2xxjprsp?q=view.getName%28%29+%3D%3D+%27canvas%27&page=1&refer=5zck4n7dm6hiefi5#query:view.getName%28%29%20%3D%3D%20%27canvas%27+page:1+mid:q2q7qzrk2lyjjxy4+state:results
for an earlier discussion of this issue.
The spec here is just odd, as many of the enums in opensocial have
lowercased values for the uppercase constants; I don't know why this
one doesn't, as the overwhelming usage of view names in the wild
appears to be lowercase, not uppercase.
So, on the whole, I'm extremely ambivalent about making this change.
On Fri, Mar 27, 2009 at 2:33 PM, <jo...@gmail.com> wrote:
> Reviewers: shindig.remailer,
>
> Description:
> Changes the canonical name of OpenSocial views, in the default container
> config, to upper-cased versions of themselves. Aliases using lower-cased
> names are provided.
>
> This makes it possible for an OpenSocial app rendered using Shindig to
> retrieve (in JS) its current view and meaningfully compare the resulting
> name (without modification to gadgets.views.ViewType values, all of
> which are capitalized.
>
> Please review this at http://codereview.appspot.com/28128
>
> Affected files:
> container.js
>
>
> Index: container.js
> ===================================================================
> --- container.js (revision 759009)
> +++ container.js (working copy)
> @@ -97,15 +97,15 @@
> "jsonProxyUrl" : "http://%host%/gadgets/makeRequest"
> },
> "views" : {
> - "profile" : {
> + "PROFILE" : {
> "isOnlyVisible" : false,
> "urlTemplate" : "http://localhost/gadgets/profile?{var}",
> - "aliases": ["DASHBOARD", "default"]
> + "aliases": ["DASHBOARD", "profile", "default"]
> },
> - "canvas" : {
> + "CANVAS" : {
> "isOnlyVisible" : true,
> "urlTemplate" : "http://localhost/gadgets/canvas?{var}",
> - "aliases" : ["FULL_PAGE"]
> + "aliases" : ["FULL_PAGE", "canvas"]
> }
> },
> "rpc" : {
>
>
>