You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/01/23 12:46:34 UTC

[GitHub] [maven-shared-utils] elharo opened a new pull request #78: remove unused plexus dependency

elharo opened a new pull request #78:
URL: https://github.com/apache/maven-shared-utils/pull/78


   @michael-o 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] MartinKanters commented on pull request #78: remove unused plexus dependency

Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #78:
URL: https://github.com/apache/maven-shared-utils/pull/78#issuecomment-821187798


   @elharo Is there any specific reason @michael-o should look at this? IMO I would say that if the code still compiles without this dependency, we should be good in general?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] slachiewicz commented on pull request #78: remove unused plexus dependency

Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #78:
URL: https://github.com/apache/maven-shared-utils/pull/78#issuecomment-821785174


   Build failed:
   
   ------
   
   [ERROR] /home/jenkins/workspace/en-box_maven-shared-utils_master@2/m/src/main/java/org/apache/maven/shared/utils/cli/javatool/AbstractJavaTool.java:[28,35] package org.codehaus.plexus.logging does not exist


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] elharo commented on pull request #78: remove unused plexus dependency

Posted by GitBox <gi...@apache.org>.
elharo commented on pull request #78:
URL: https://github.com/apache/maven-shared-utils/pull/78#issuecomment-821566030


   Anyone can review. I try to request reviews roughly round robin amongst active committers unless I believe there's a particular reason someone might be interested in a PR. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] MartinKanters commented on pull request #78: remove unused plexus dependency

Posted by GitBox <gi...@apache.org>.
MartinKanters commented on pull request #78:
URL: https://github.com/apache/maven-shared-utils/pull/78#issuecomment-821809696


   @slachiewicz @elharo looks like we could use GitHub Actions in this repo.. :) 
   Imo we should revert this PR, do you guys have any concern with that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven-shared-utils] slachiewicz merged pull request #78: remove unused plexus dependency

Posted by GitBox <gi...@apache.org>.
slachiewicz merged pull request #78:
URL: https://github.com/apache/maven-shared-utils/pull/78


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org