[GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...

[hanm <gi...@git.apache.org>]

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/447#discussion_r205340787
  
    --- Diff: src/java/main/org/apache/zookeeper/server/SessionTracker.java ---
    @@ -47,21 +47,20 @@
         long createSession(int sessionTimeout);
     
         /**
    -     * Add a global session to those being tracked.
    +     * Track the session expire, not add to ZkDb.
          * @param id sessionId
          * @param to sessionTimeout
          * @return whether the session was newly added (if false, already existed)
          */
    -    boolean addGlobalSession(long id, int to);
    +    boolean trackSession(long id, int to);
     
         /**
    -     * Add a session to those being tracked. The session is added as a local
    -     * session if they are enabled, otherwise as global.
    +     * Add the session to the under layer storage.
          * @param id sessionId
          * @param to sessionTimeout
          * @return whether the session was newly added (if false, already existed)
    --- End diff --
    
    Similarly it'll be great if the comment on the return value here is updated.


---