[jira] [Work logged] (HIVE-27137) Remove HIVE_IN_TEST_ICEBERG flag

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-27137?focusedWorklogId=850910&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850910 ]

ASF GitHub Bot logged work on HIVE-27137:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/23 14:16
            Start Date: 14/Mar/23 14:16
    Worklog Time Spent: 10m 
      Work Description: InvisibleProgrammer opened a new pull request, #4118:
URL: https://github.com/apache/hive/pull/4118

   That test flag is not in use. And in the long term, using those flags leads to hard to test code so it is logical to remove them. And as it is unused, it is the best time to remove that. 
   
   ### What changes were proposed in this pull request?
   Remove HIVE_IN_TEST_ICEBERG flag.
   
   
   ### Why are the changes needed?
   It is unused.
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   By running the tests in the pipeline.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 850910)
    Remaining Estimate: 0h
            Time Spent: 10m

> Remove HIVE_IN_TEST_ICEBERG flag
> --------------------------------
>
>                 Key: HIVE-27137
>                 URL: https://issues.apache.org/jira/browse/HIVE-27137
>             Project: Hive
>          Issue Type: Improvement
>          Components: Iceberg integration
>            Reporter: Zsolt Miskolczi
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Remove the HIVE_IN_TEST_ICEBERG flag from the production code.
> Remove code snippet from TxnHandler and update unit tests which are expecting the exception. 
> {code:java}
> if (lc.isSetOperationType() && lc.getOperationType() == DataOperationType.UNSET &&
>         ((MetastoreConf.getBoolVar(conf, ConfVars.HIVE_IN_TEST) ||
>             MetastoreConf.getBoolVar(conf, ConfVars.HIVE_IN_TEZ_TEST)) &&
>             !MetastoreConf.getBoolVar(conf, ConfVars.HIVE_IN_TEST_ICEBERG))) { 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)