You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/07/26 10:12:58 UTC
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1376: MINIFICPP-1890 Fix the Kubernetes build on Centos
fgerlits opened a new pull request, #1376:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1376
https://issues.apache.org/jira/browse/MINIFICPP-1890
* workaround for missing `SOURCE_SUBDIR` option in CMake < 3.18
* enable the Kubernetes extension in the `centos` CI build
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1376: MINIFICPP-1890 Fix the Kubernetes build on Centos
Posted by GitBox <gi...@apache.org>.
szaszm commented on PR #1376:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1376#issuecomment-1196909002
> > I'm not a fan of extending the scope of the centos CI build, as expressed in more detail in #1374. I realize that this issue would've been caught earlier with that, but our CI jobs already use too much time.
> > +1 for the rest.
>
> In that case I will merge this PR and we can discuss further in #1374 and may remove the added extension there.
Sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1376: MINIFICPP-1890 Fix the Kubernetes build on Centos
Posted by GitBox <gi...@apache.org>.
lordgamez commented on PR #1376:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1376#issuecomment-1196907489
> I'm not a fan of extending the scope of the centos CI build, as expressed in more detail in #1374. I realize that this issue would've been caught earlier with that, but our CI jobs already use too much time.
>
> +1 for the rest.
In that case I will merge this PR and we can discuss in https://github.com/apache/nifi-minifi-cpp/pull/1374 and may remove the added extension there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1376: MINIFICPP-1890 Fix the Kubernetes build on Centos
Posted by GitBox <gi...@apache.org>.
szaszm commented on PR #1376:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1376#issuecomment-1196885649
I'm not a fan of extending the scope of the centos CI build, as expressed in more detail in #1374. I realize that this issue would've been caught earlier with that, but our CI jobs already use too much time.
+1 for the rest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez closed pull request #1376: MINIFICPP-1890 Fix the Kubernetes build on Centos
Posted by GitBox <gi...@apache.org>.
lordgamez closed pull request #1376: MINIFICPP-1890 Fix the Kubernetes build on Centos
URL: https://github.com/apache/nifi-minifi-cpp/pull/1376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org