You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2009/05/24 14:58:45 UTC
[jira] Created: (LUCENE-1657) Make "boolean readOnly" a required
arg to IndexReader.open
Make "boolean readOnly" a required arg to IndexReader.open
----------------------------------------------------------
Key: LUCENE-1657
URL: https://issues.apache.org/jira/browse/LUCENE-1657
Project: Lucene - Java
Issue Type: Improvement
Components: Index
Reporter: Michael McCandless
Assignee: Michael McCandless
Priority: Minor
Fix For: 2.9
Most apps don't need read/write IndexReader, and, a readOnly
IndexReader has better concurrent performance.
I'd love to simply default readOnly to true, and you'd have to specify
"false" if you want a read/write reader (I think that's the natural
default), but I think that'd break too many back-compat cases.
So the workaround is to make the parameter explicit, in 2.9.
I think even for IndexSearcher's methods that open an IndexReader
under the hood, we should also make the parameter explicit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1657) Make "boolean readOnly" a required
arg to IndexReader.open
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-1657.
----------------------------------------
Resolution: Fixed
> Make "boolean readOnly" a required arg to IndexReader.open
> ----------------------------------------------------------
>
> Key: LUCENE-1657
> URL: https://issues.apache.org/jira/browse/LUCENE-1657
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1657.patch
>
>
> Most apps don't need read/write IndexReader, and, a readOnly
> IndexReader has better concurrent performance.
> I'd love to simply default readOnly to true, and you'd have to specify
> "false" if you want a read/write reader (I think that's the natural
> default), but I think that'd break too many back-compat cases.
> So the workaround is to make the parameter explicit, in 2.9.
> I think even for IndexSearcher's methods that open an IndexReader
> under the hood, we should also make the parameter explicit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1657) Make "boolean readOnly" a required
arg to IndexReader.open
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-1657:
---------------------------------------
Attachment: LUCENE-1657.patch
Attached patch. I plan to commit in a day or two.
> Make "boolean readOnly" a required arg to IndexReader.open
> ----------------------------------------------------------
>
> Key: LUCENE-1657
> URL: https://issues.apache.org/jira/browse/LUCENE-1657
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1657.patch
>
>
> Most apps don't need read/write IndexReader, and, a readOnly
> IndexReader has better concurrent performance.
> I'd love to simply default readOnly to true, and you'd have to specify
> "false" if you want a read/write reader (I think that's the natural
> default), but I think that'd break too many back-compat cases.
> So the workaround is to make the parameter explicit, in 2.9.
> I think even for IndexSearcher's methods that open an IndexReader
> under the hood, we should also make the parameter explicit.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org