[GitHub] mistercrunch commented on a change in pull request #5302: [DeckGL] Raise error with null values

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5302: [DeckGL] Raise error with null values
URL: https://github.com/apache/incubator-superset/pull/5302#discussion_r198663008
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2107,6 +2108,10 @@ def tupleify(s):
             df[key] = list(zip(latlong.apply(lambda x: x[0]),
                                latlong.apply(lambda x: x[1])))
             del df[spatial.get('geohashCol')]
+
+        if df[key] is None:
 
 Review comment:
   (optional)`df.get(key) is None:` would protect against KeyError (not sure if they're possible in this context)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org