[jira] [Commented] (FLINK-4081) FieldParsers should support empty strings

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393895#comment-15393895 ] 

ASF GitHub Bot commented on FLINK-4081:
---------------------------------------

GitHub user twalthr opened a pull request:

    https://github.com/apache/flink/pull/2297

    [FLINK-4081] [core] [table] FieldParsers should support empty strings

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    This PR adds the FieldParser error state `EMPTY_STRING` to all FieldParsers. Until now the behavior was inconsistent, e.g. IntParser had it but FloatParser not. This PR allows for `null` values in advanced input formats such as `RowCsvInputFormat`. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/twalthr/flink FLINK-4081

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2297.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2297
    
----
commit c04532ec69a42993e7070f959d265e5d0ff39704
Author: twalthr <tw...@apache.org>
Date:   2016-07-26T14:24:24Z

    [FLINK-4081] [core] [table] FieldParsers should support empty strings

----


> FieldParsers should support empty strings
> -----------------------------------------
>
>                 Key: FLINK-4081
>                 URL: https://issues.apache.org/jira/browse/FLINK-4081
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: Flavio Pompermaier
>            Assignee: Timo Walther
>              Labels: csvparser, table-api
>
> In order to parse CSV files using the new Table API that converts rows to Row objects (that support null values), FiledParser implementations should support emptry strings setting the parser state to ParseErrorState.EMPTY_STRING (for example FloatParser and DoubleParser doesn't respect this constraint)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)