[GitHub] [spark] pan3793 commented on a diff in pull request #41201: [SPARK-43540][K8S][CORE] Add working directory into classpath on the driver in K8S cluster mode

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #41201:
URL: https://github.com/apache/spark/pull/41201#discussion_r1196873001


##########
core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala:
##########
@@ -425,7 +428,7 @@ private[spark] class SparkSubmit extends Logging {
             case (localResources, resolvedUri) =>
               val source = new File(localResources.getPath)
               val dest = new File(
-                ".",
+                workingDirectory,
                 if (resolvedUri.getFragment != null) resolvedUri.getFragment else source.getName)

Review Comment:
   Since `.` is participated in, can we call `File#getCanonicalFile` before assigning `source` and `dest` here to avoid the following message?
   
   ```log
   Files  ... from /tmp/spark-1a68de84-0fb2-4cf6-8f7a-302c24509935/xyz-plugin-spark3-2.12-20230516-131757.jar.jar to /opt/spark/work-dir/./xyz-plugin-spark3-2.12-20230516-131757.jar
   ```
   
   And the logging statement can be simplified to
   
   ```patch
   -logInfo(
   -  s"Files  $resolvedUri " +
   -    s"from ${source.getAbsolutePath} to ${dest.getAbsolutePath}")
   +logInfo(s"Files $resolvedUri from $source to $dest")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org