You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2020/12/26 15:21:05 UTC
[GitHub] [maven-artifact-transfer] slachiewicz opened a new pull request #20: Mshared 944
slachiewicz opened a new pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] slachiewicz commented on a change in pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#discussion_r549838430
##########
File path: pom.xml
##########
@@ -165,12 +165,12 @@
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
- <version>3.0</version>
+ <version>3.1.1</version>
Review comment:
Sure, will fix this next time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] michael-o commented on a change in pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#discussion_r549743091
##########
File path: pom.xml
##########
@@ -165,12 +165,12 @@
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-core</artifactId>
- <version>3.0</version>
+ <version>3.1.1</version>
Review comment:
I think this should be moved to a property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] slachiewicz commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752072730
there is nothing special - lots of removal of old maven 3.0 stuff + replacement of reflections to just us normal direct call to exposed API. No need to spent too much time here.
CI is green https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-artifact-transfer/job/MSHARED-944/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752506877
I still consider adding the `org.apache.maven.shared.transfer.project` package a bad choice, because it introduces a dependency on Maven.
https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies does indeed talk about adding maven-artifact-transfer, but https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=155749857 should contain the removal of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] michael-o commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-751367361
Massive, will need some time for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] rfscholte closed pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
rfscholte closed pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752440522
Please don't do this. The intention of maven-artifact-transfer is a bridge to any Aether implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] slachiewicz commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752074009
With these changes, it should be easier to move forward with maven-dependency-tree and other plugins - to not fight with old dependencies.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] slachiewicz commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752469411
Do we have anywhere documented this recommendation? I think we still have on wiki to use this artefact.
Also with this changes we can easily switch to new aether impl by dep update plus remove redundant code/simplify other projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] [maven-artifact-transfer] rfscholte commented on pull request #20: [MSHARED-944] Drop support for Maven 3.0. Require 3.1.1
Posted by GitBox <gi...@apache.org>.
rfscholte commented on pull request #20:
URL: https://github.com/apache/maven-artifact-transfer/pull/20#issuecomment-752454346
Sorry @slachiewicz if you've spend a lot of time on this, but I need to close this. Once everything is using Maven 3.1+ we can simply archive maven-artifact-transfer because it has become an unnecessary abstraction layer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org