[GitHub] [cassandra] jeffwidman commented on a change in pull request #1527: CASSANDRA-17480 resolve several pylint issues

[GitBox <gi...@apache.org>]

jeffwidman commented on a change in pull request #1527:
URL: https://github.com/apache/cassandra/pull/1527#discussion_r836192066



##########
File path: bin/cqlsh.py
##########
@@ -35,6 +35,9 @@
 from glob import glob
 from uuid import UUID
 
+import configparser
+from io import StringIO

Review comment:
       These are both stdlib, so why a separate section? Why not delete the blank line at line 37?

##########
File path: bin/cqlsh.py
##########
@@ -870,7 +870,7 @@ def use_stdin_reader(self, until='', prompt=''):
                 return
             yield newline
 
-    def cmdloop(self):
+    def cmdloop(self, intro=None):

Review comment:
       I don't see this var being used within this function, so why is this needed? Am I just blind somehow?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org