You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/05/06 20:29:28 UTC

[GitHub] [trafficcontrol] rob05c commented on a diff in pull request #6812: Correct __HOSTNAME__ for short hostName unknown files generated by T3C

rob05c commented on code in PR #6812:
URL: https://github.com/apache/trafficcontrol/pull/6812#discussion_r867197007


##########
lib/go-atscfg/serverunknown.go:
##########
@@ -75,7 +75,7 @@ func MakeServerUnknown(
 		txt += pa.Val + "\n"
 	}
 
-	txt = strings.Replace(txt, `__HOSTNAME__`, *server.HostName+`.`+*server.DomainName, -1)
+	txt = strings.Replace(txt, `__HOSTNAME__`, *server.HostName, -1)

Review Comment:
   Nitpick: This could be removed, since t3c-preprocess will do this. But not a huge deal, behaves correctly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org