You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2016/06/20 17:55:28 UTC
jclouds git commit: Remove scoping annotations on abstract types
Repository: jclouds
Updated Branches:
refs/heads/master d6454b822 -> 1d192dfe5
Remove scoping annotations on abstract types
These annotations are not meaningful. Found via error-prone.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/1d192dfe
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/1d192dfe
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/1d192dfe
Branch: refs/heads/master
Commit: 1d192dfe56e446b4ecd4a29bde8ad7ad80998ee1
Parents: d6454b8
Author: Andrew Gaul <ga...@apache.org>
Authored: Mon Jun 20 10:49:52 2016 -0700
Committer: Andrew Gaul <ga...@apache.org>
Committed: Mon Jun 20 10:54:52 2016 -0700
----------------------------------------------------------------------
.../internal/RefreshAndDoubleCheckOnFailUnlessStatusInvalid.java | 2 --
core/src/main/java/org/jclouds/internal/BaseView.java | 3 ---
.../org/jclouds/json/internal/NullHackJsonLiteralAdapter.java | 3 ---
3 files changed, 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/1d192dfe/compute/src/main/java/org/jclouds/compute/predicates/internal/RefreshAndDoubleCheckOnFailUnlessStatusInvalid.java
----------------------------------------------------------------------
diff --git a/compute/src/main/java/org/jclouds/compute/predicates/internal/RefreshAndDoubleCheckOnFailUnlessStatusInvalid.java b/compute/src/main/java/org/jclouds/compute/predicates/internal/RefreshAndDoubleCheckOnFailUnlessStatusInvalid.java
index 2b1e43d..c7220c0 100644
--- a/compute/src/main/java/org/jclouds/compute/predicates/internal/RefreshAndDoubleCheckOnFailUnlessStatusInvalid.java
+++ b/compute/src/main/java/org/jclouds/compute/predicates/internal/RefreshAndDoubleCheckOnFailUnlessStatusInvalid.java
@@ -23,7 +23,6 @@ import java.util.Set;
import java.util.concurrent.atomic.AtomicReference;
import javax.annotation.Resource;
-import javax.inject.Singleton;
import org.jclouds.compute.domain.ComputeMetadataIncludingStatus;
import org.jclouds.logging.Logger;
@@ -37,7 +36,6 @@ import com.google.common.collect.ImmutableSet;
* resource, so as to eliminate a redundant {@link ComputeService#getNodeMetadata} call after the
* predicate passes.
*/
-@Singleton
public abstract class RefreshAndDoubleCheckOnFailUnlessStatusInvalid<S extends Enum<S>, C extends ComputeMetadataIncludingStatus<S>> implements Predicate<AtomicReference<C>> {
private final S intended;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/1d192dfe/core/src/main/java/org/jclouds/internal/BaseView.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/jclouds/internal/BaseView.java b/core/src/main/java/org/jclouds/internal/BaseView.java
index e7ab845..153bfc5 100644
--- a/core/src/main/java/org/jclouds/internal/BaseView.java
+++ b/core/src/main/java/org/jclouds/internal/BaseView.java
@@ -21,8 +21,6 @@ import static com.google.common.base.Preconditions.checkNotNull;
import java.io.Closeable;
-import javax.inject.Singleton;
-
import org.jclouds.Context;
import org.jclouds.View;
import org.jclouds.location.Provider;
@@ -34,7 +32,6 @@ import com.google.common.collect.ForwardingObject;
import com.google.common.reflect.TypeParameter;
import com.google.common.reflect.TypeToken;
-@Singleton
public abstract class BaseView extends ForwardingObject implements View {
private final Context backend;
http://git-wip-us.apache.org/repos/asf/jclouds/blob/1d192dfe/core/src/main/java/org/jclouds/json/internal/NullHackJsonLiteralAdapter.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/jclouds/json/internal/NullHackJsonLiteralAdapter.java b/core/src/main/java/org/jclouds/json/internal/NullHackJsonLiteralAdapter.java
index b1a23d9..1566176 100644
--- a/core/src/main/java/org/jclouds/json/internal/NullHackJsonLiteralAdapter.java
+++ b/core/src/main/java/org/jclouds/json/internal/NullHackJsonLiteralAdapter.java
@@ -20,8 +20,6 @@ import java.io.IOException;
import java.io.Writer;
import java.lang.reflect.Field;
-import javax.inject.Singleton;
-
import com.google.common.base.Throwables;
import com.google.gson.TypeAdapter;
import com.google.gson.internal.bind.TypeAdapters;
@@ -33,7 +31,6 @@ import com.google.gson.stream.JsonWriter;
*
* @see <a href="http://code.google.com/p/google-gson/issues/detail?id=326" />
*/
-@Singleton
public abstract class NullHackJsonLiteralAdapter<L> extends TypeAdapter<L> {
@Override