[GitHub] [phoenix] palashc commented on a diff in pull request #1506: PHOENIX-6761 : Phoenix Client Side Metadata Caching Improvement

[GitBox <gi...@apache.org>]

palashc commented on code in PR #1506:
URL: https://github.com/apache/phoenix/pull/1506#discussion_r1017067009


##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/AppendOnlySchemaIT.java:
##########
@@ -112,9 +114,9 @@ private void testTableWithSameSchema(boolean notExists, boolean sameClient) thro
             }
             
             // verify getTable rpcs
-            verify(connectionQueryServices, sameClient ? never() : times(1))
-                    .getTable((PName) isNull(), eq(new byte[0]),
-                            eq(Bytes.toBytes(viewName)), anyLong(), anyLong());
+            verify(connectionQueryServices, never())

Review Comment:
   This test was checking if there was a `CQSI.getTable` call when a different connection is used to execute the same create ddl. With the new design, there will be no call to `CQSI.getTable` since the other connection will find the table metadata in the CQSI cache. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org