You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/19 14:20:05 UTC

[GitHub] [flink] rmetzger commented on a change in pull request #14694: [FLINK-19158][e2e] Fix wget timeout mechanism and cache config

rmetzger commented on a change in pull request #14694:
URL: https://github.com/apache/flink/pull/14694#discussion_r560208530



##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/cache/AbstractDownloadCache.java
##########
@@ -128,7 +128,11 @@ public Path getOrDownload(final String url, final Path targetDir) throws IOExcep
             Files.createDirectories(scopedDownloadDir);
             log.info("Downloading {}.", url);
             AutoClosableProcess.create(
-                            CommandLineWrapper.wget(url).targetDir(scopedDownloadDir).build())
+                            CommandLineWrapper.wget(url)
+                                    .targetDir(scopedDownloadDir)
+                                    .timeoutSecs(
+                                            downloadGlobalTimeout.getSeconds() / downloadMaxRetries)

Review comment:
       overlooked it, thx




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org