You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2007/06/12 18:02:27 UTC

[jira] Created: (WICKET-641) wicket thread handling is not fully servlet container aware

wicket thread handling is not fully servlet container aware
-----------------------------------------------------------

                 Key: WICKET-641
                 URL: https://issues.apache.org/jira/browse/WICKET-641
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.3.0-beta1
            Reporter: Peter Ertl


I found these issues in wicket:

(1) org.apache.wicket.util.file.FileCleaner will never terminate it's reaper thread once it has been started
(2) org.apache.wicket.util.thread.Task will not immediately stop when calling stop() but wait at least until it's next point of execution (which could take very long!)

In a servlet container, any kind of thread should be killed in WebApplication#destroy or equivalent and terminate as quick as possible / immediately.

(2) should not rely on the 'stop' variable but use Thread#interrupt and InterruptedException instead.

*IMHO* terminating threads in general is done best by using Thread#interrupt as suggested by Sun.

delaying / ignoring termination of threads could leave stale file locks, continue to use memory and cause other types of resource problems....

Starting / stopping web applications is not restricted to hot deploy while developing but some production servers are usually not shutdown for re-deployment so this issue could be critical in that case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (WICKET-641) wicket thread handling is not fully servlet container aware

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Juergen Donnerstag resolved WICKET-641.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-rc1
         Assignee: Juergen Donnerstag

thanks, it is fixed now

> wicket thread handling is not fully servlet container aware
> -----------------------------------------------------------
>
>                 Key: WICKET-641
>                 URL: https://issues.apache.org/jira/browse/WICKET-641
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Peter Ertl
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-rc1
>
>
> I found these issues in wicket:
> (1) org.apache.wicket.util.file.FileCleaner will never terminate it's reaper thread once it has been started
> (2) org.apache.wicket.util.thread.Task will not immediately stop when calling stop() but wait at least until it's next point of execution (which could take very long!)
> In a servlet container, any kind of thread should be killed in WebApplication#destroy or equivalent and terminate as quick as possible / immediately.
> (2) should not rely on the 'stop' variable but use Thread#interrupt and InterruptedException instead.
> *IMHO* terminating threads in general is done best by using Thread#interrupt as suggested by Sun.
> delaying / ignoring termination of threads could leave stale file locks, continue to use memory and cause other types of resource problems....
> Starting / stopping web applications is not restricted to hot deploy while developing but some production servers are usually not shutdown for re-deployment so this issue could be critical in that case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WICKET-641) wicket thread handling is not fully servlet container aware

Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Maw updated WICKET-641:
--------------------------------

    Fix Version/s:     (was: 1.3.0-rc1)
                   1.3.0-beta3

> wicket thread handling is not fully servlet container aware
> -----------------------------------------------------------
>
>                 Key: WICKET-641
>                 URL: https://issues.apache.org/jira/browse/WICKET-641
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-beta1
>            Reporter: Peter Ertl
>            Assignee: Juergen Donnerstag
>             Fix For: 1.3.0-beta3
>
>
> I found these issues in wicket:
> (1) org.apache.wicket.util.file.FileCleaner will never terminate it's reaper thread once it has been started
> (2) org.apache.wicket.util.thread.Task will not immediately stop when calling stop() but wait at least until it's next point of execution (which could take very long!)
> In a servlet container, any kind of thread should be killed in WebApplication#destroy or equivalent and terminate as quick as possible / immediately.
> (2) should not rely on the 'stop' variable but use Thread#interrupt and InterruptedException instead.
> *IMHO* terminating threads in general is done best by using Thread#interrupt as suggested by Sun.
> delaying / ignoring termination of threads could leave stale file locks, continue to use memory and cause other types of resource problems....
> Starting / stopping web applications is not restricted to hot deploy while developing but some production servers are usually not shutdown for re-deployment so this issue could be critical in that case.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.