[GitHub] [spark] LuciferYang commented on a diff in pull request #40628: [SPARK-42999][Connect] Dataset#foreach, foreachPartition

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #40628:
URL: https://github.com/apache/spark/pull/40628#discussion_r1161399737


##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/UserDefinedFunctionE2ETestSuite.scala:
##########
@@ -128,4 +130,72 @@ class UserDefinedFunctionE2ETestSuite extends RemoteSparkSession {
       .collect()
     assert(result.sorted.toSeq === Seq(23, 25, 25, 27))
   }
+
+  test("Dataset foreach") {

Review Comment:
   How to test the new case with maven ? @zhenlineo 
   
   I run the following commands:
   
   ```
   build/mvn clean install -pl connector/connect/server -am -DskipTests
   build/mvn clean install -pl assembly -am -DskipTests
   build/mvn clean install -pl connector/connect/client
   ```
   
   there are 15 test failed in this one:
   
   ```
   - Dataset typed filter *** FAILED ***
     io.grpc.StatusRuntimeException: INTERNAL: org.apache.spark.sql.UserDefinedFunctionE2ETestSuite
     at io.grpc.Status.asRuntimeException(Status.java:535)
     at io.grpc.stub.ClientCalls$BlockingResponseStream.hasNext(ClientCalls.java:660)
     at org.apache.spark.sql.connect.client.SparkResult.org$apache$spark$sql$connect$client$SparkResult$$processResponses(SparkResult.scala:61)
     at org.apache.spark.sql.connect.client.SparkResult.length(SparkResult.scala:106)
     at org.apache.spark.sql.connect.client.SparkResult.toArray(SparkResult.scala:123)
     at org.apache.spark.sql.Dataset.$anonfun$collect$1(Dataset.scala:2687)
     at org.apache.spark.sql.Dataset.withResult(Dataset.scala:3088)
     at org.apache.spark.sql.Dataset.collect(Dataset.scala:2686)
     at org.apache.spark.sql.Dataset.collectAsList(Dataset.scala:2700)
     at org.apache.spark.sql.UserDefinedFunctionE2ETestSuite.$anonfun$new$1(UserDefinedFunctionE2ETestSuite.scala:38)
     ...
   
   *** 15 TESTS FAILED ***
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org