[jira] [Updated] (MINIFICPP-1497) Remove misleading ThreadPoolAdjust integration test

["Martin Zink (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MINIFICPP-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Zink updated MINIFICPP-1497:
-----------------------------------
    Status: Patch Available  (was: Open)

https://github.com/apache/nifi-minifi-cpp/pull/1009

> Remove misleading ThreadPoolAdjust integration test
> ---------------------------------------------------
>
>                 Key: MINIFICPP-1497
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1497
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Martin Zink
>            Assignee: Martin Zink
>            Priority: Trivial
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Based on the name ThreadPoolAdjust, it is implied it tests the adjustments to the thread-pool or something along those lines, however _extensions/http-curl/tests/ThreadPoolAdjust.cpp_ is just a copy of _extensions/http-curl/tests/HttpPostIntegrationTest.cpp_ (only difference is that in the configuration nifi.flow.engine.threads is set to 1 instead of 8).
> The configuration yml (_libminifi/test/resources/ThreadPoolAdjust.yml_) is also almost the same as to what the HttpPostIntegrationTest uses (_libminifi/test/resources/TestHTTPPost.yml_)
> The test itself only runs assertion whether the InvokeHTTP processor is successfully started, nothing related to the threadpool.
> Having this test is currently misleading, we could just rename it but since it doesn't give anymore coverage than the aforementioned HttpPostIntegrationTest, I think we should just remove it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)