You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2009/01/10 02:07:59 UTC

[jira] Created: (THRIFT-255) TSimpleFileTransport

TSimpleFileTransport
--------------------

                 Key: THRIFT-255
                 URL: https://issues.apache.org/jira/browse/THRIFT-255
             Project: Thrift
          Issue Type: New Feature
          Components: Library (C++)
            Reporter: David Reiss


TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-255) TSimpleFileTransport

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-255:
-------------------------------

    Attachment: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>         Attachments: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch
>
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "Anthony Giardullo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674388#action_12674388 ] 

Anthony Giardullo commented on THRIFT-255:
------------------------------------------

Make sure to change the namespace from facebook to apache.  Otherwise, looks good.

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "Jérémie BORDIER (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688007#action_12688007 ] 

Jérémie BORDIER commented on THRIFT-255:
----------------------------------------

I agree with Ben Maurer on the first two points. David could you update the patch and switch to the new namespaces ? It's a useful tool and a triviail patch, would be cool to get this commited.

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689309#action_12689309 ] 

David Reiss commented on THRIFT-255:
------------------------------------

Updated namespaces, moved default args, used a reference for the path, and documented O_APPEND.

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>         Attachments: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch
>
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-255) TSimpleFileTransport

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-255:
-------------------------------

    Attachment: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>         Attachments: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch
>
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-255) TSimpleFileTransport

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-255.
--------------------------------

    Resolution: Fixed
      Assignee: David Reiss

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>            Assignee: David Reiss
>         Attachments: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch
>
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "Jérémie BORDIER (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689318#action_12689318 ] 

Jérémie BORDIER commented on THRIFT-255:
----------------------------------------

Looks perfect, +1 !

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>         Attachments: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch
>
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-255) TSimpleFileTransport

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss updated THRIFT-255:
-------------------------------

    Attachment:     (was: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch)

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>         Attachments: 0001-THRIFT-255.-cpp-Add-TSimpleFileTransport-a-wrapper.patch
>
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662591#action_12662591 ] 

David Reiss commented on THRIFT-255:
------------------------------------

http://gitweb.thrift-rpc.org/?p=thrift.git;a=commitdiff;h=c5e29c5

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "Ben Maurer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674827#action_12674827 ] 

Ben Maurer commented on THRIFT-255:
-----------------------------------

1) const std::string& for path
2) does specifying default params in just the .cpp file really work? seems like the compiler would have trouble understanding that.
3) Document using O_APPEND. Maybe allow overwriting as another option

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "Jérémie BORDIER (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688496#action_12688496 ] 

Jérémie BORDIER commented on THRIFT-255:
----------------------------------------

The patch does have little glitches and just does not apply anymore. If David doesn't show up on this one in a couple of days, i'll update it by myself.

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (THRIFT-255) TSimpleFileTransport

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688491#action_12688491 ] 

Bryan Duxbury commented on THRIFT-255:
--------------------------------------

What are we waiting on to get this committed?

> TSimpleFileTransport
> --------------------
>
>                 Key: THRIFT-255
>                 URL: https://issues.apache.org/jira/browse/THRIFT-255
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C++)
>            Reporter: David Reiss
>
> TSimpleFileTransport is a thin wrapper around TFDTransport that simplifies the process of opening a file.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.