You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by John Morrison <jo...@experian.com> on 2000/06/22 16:13:24 UTC
CVS fails to build...
There's a close bracket missing at the end of line 370 in
org.apache.cocoon.Engine for Cocoon 1
Re: CVS fails to build...
Posted by James Duncan Davidson <ja...@eng.sun.com>.
on 2000/06/22 12:07, Stefano Mazzocchi at stefano@apache.org wrote:
>> And it wasn't compiled before being committed? :)
>
> Because I have barely time enough to breath these days :)
Oh, I know that feeling. :)
> I know I know no excuse...
This is where the gentle process of whacking each other comes in handy. :)
.duncan
Re: CVS fails to build...
Posted by Stefano Mazzocchi <st...@apache.org>.
James Duncan Davidson wrote:
>
> on 2000/06/22 10:55, Hans Ulrich Niedermann at
> niedermann@isd.uni-stuttgart.de wrote:
>
> > John Morrison <jo...@experian.com> writes:
> >
> >> There's a close bracket missing at the end of line 370 in
> >> org.apache.cocoon.Engine for Cocoon 1
> >
> > You're right. My patch included the missing bracket, but somehow
> > Stefano seems to have forgotten it when patching. Patch attached.
>
> And it wasn't compiled before being committed? :)
Because I have barely time enough to breath these days :)
I know I know no excuse...
--
Stefano Mazzocchi One must still have chaos in oneself to be
able to give birth to a dancing star.
<st...@apache.org> Friedrich Nietzsche
--------------------------------------------------------------------
Missed us in Orlando? Make it up with ApacheCON Europe in London!
------------------------- http://ApacheCon.Com ---------------------
Re: CVS fails to build...
Posted by James Duncan Davidson <ja...@eng.sun.com>.
on 2000/06/22 10:55, Hans Ulrich Niedermann at
niedermann@isd.uni-stuttgart.de wrote:
> John Morrison <jo...@experian.com> writes:
>
>> There's a close bracket missing at the end of line 370 in
>> org.apache.cocoon.Engine for Cocoon 1
>
> You're right. My patch included the missing bracket, but somehow
> Stefano seems to have forgotten it when patching. Patch attached.
And it wasn't compiled before being committed? :)
.duncan
Re: CVS fails to build...
Posted by Hans Ulrich Niedermann <ni...@isd.uni-stuttgart.de>.
John Morrison <jo...@experian.com> writes:
> There's a close bracket missing at the end of line 370 in
> org.apache.cocoon.Engine for Cocoon 1
You're right. My patch included the missing bracket, but somehow
Stefano seems to have forgotten it when patching. Patch attached.
Uli
Index: src/org/apache/cocoon/Engine.java
===================================================================
RCS file: /home/cvspublic/xml-cocoon/src/org/apache/cocoon/Engine.java,v
retrieving revision 1.31
diff -c -r1.31 Engine.java
*** src/org/apache/cocoon/Engine.java 2000/06/21 22:09:56 1.31
--- src/org/apache/cocoon/Engine.java 2000/06/22 17:49:08
***************
*** 365,373 ****
out.println(page.getContent());
// if verbose mode is on the the output type allows it
! // and the HTTP request isn't a HEAD
// print some processing info as a comment
! if (VERBOSE && (page.isText()) && !"HEAD".equals(request.getMethod()) {
time = System.currentTimeMillis() - time;
out.println("<!-- This page was served "
+ (page.isCached() ? "from cache " : "")
--- 365,373 ----
out.println(page.getContent());
// if verbose mode is on the the output type allows it
! // and the HTTP request isn't a HEAD
// print some processing info as a comment
! if ( VERBOSE && (page.isText()) && !"HEAD".equals(request.getMethod()) ) {
time = System.currentTimeMillis() - time;
out.println("<!-- This page was served "
+ (page.isCached() ? "from cache " : "")