You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2023/01/11 21:41:52 UTC

[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #1938: [TINKERPOP-2844] Adds tests for per-request-settings in GLV's

vkagamlyk commented on code in PR #1938:
URL: https://github.com/apache/tinkerpop/pull/1938#discussion_r1067484871


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/test/integration/client-behavior-tests.js:
##########
@@ -64,5 +63,15 @@ describe('Client', function () {
 
             await noUserAgentClient.close();
         });
+        it('should send per request settings to server', async function () {
+            let resultSet = await client.submit('1', null, {

Review Comment:
   better to use `const` to declare immutable variable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org