You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "MaxGekk (via GitHub)" <gi...@apache.org> on 2023/12/21 14:50:13 UTC
[PR] [WIP][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
MaxGekk opened a new pull request, #44449:
URL: https://github.com/apache/spark/pull/44449
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44449:
URL: https://github.com/apache/spark/pull/44449#discussion_r1444308138
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -633,13 +633,31 @@ abstract class JdbcDialect extends Serializable with Logging {
* @param e The dialect specific exception.
* @param errorClass The error class assigned in the case of an unclassified `e`
* @param messageParameters The message parameters of `errorClass`
+ * @param description The error description
* @return `AnalysisException` or its sub-class.
*/
def classifyException(
e: Throwable,
errorClass: String,
- messageParameters: Map[String, String]): AnalysisException = {
- new AnalysisException(errorClass, messageParameters, cause = Some(e))
+ messageParameters: Map[String, String],
+ description: String): AnalysisException = {
+ classifyException(description, e)
Review Comment:
This might be not fully compatible with existing JDBC dialects because values in `messageParameters` has been preprocessed already like quoting, and a JDBC dialect could use regexp for parsing parameters from `mesage`/`description`. Theoretically, it can break the regexps.
And if we pass the quoting values to an JDBC dialect, it can throw some Spark exception which performs quoting inside like `PostgresDialect` throws `NonEmptyNamespaceException`. The last one does quoting inside its constructor. Apparently, we will get double quoting values which is a bug already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44449:
URL: https://github.com/apache/spark/pull/44449#discussion_r1444308138
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -633,13 +633,31 @@ abstract class JdbcDialect extends Serializable with Logging {
* @param e The dialect specific exception.
* @param errorClass The error class assigned in the case of an unclassified `e`
* @param messageParameters The message parameters of `errorClass`
+ * @param description The error description
* @return `AnalysisException` or its sub-class.
*/
def classifyException(
e: Throwable,
errorClass: String,
- messageParameters: Map[String, String]): AnalysisException = {
- new AnalysisException(errorClass, messageParameters, cause = Some(e))
+ messageParameters: Map[String, String],
+ description: String): AnalysisException = {
+ classifyException(description, e)
Review Comment:
This might be not fully compatible with existing JDBC dialects because values in `messageParameters` has been preprocessed already like quoting, and a JDBC dialect could use regexp for parsing parameters from `mesage`/`description`. Theoretically, it can break the regexps.
And if we pass the quoting values to an JDBC dialect, it can throw some Spark exception which do quoting inside like `PostgresDialect` throws `NonEmptyNamespaceException`. The last one does quoting inside its constructor. Apparently, we will get double quoting values which is a bug already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #44449: [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException`
URL: https://github.com/apache/spark/pull/44449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44449:
URL: https://github.com/apache/spark/pull/44449#discussion_r1444308138
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -633,13 +633,31 @@ abstract class JdbcDialect extends Serializable with Logging {
* @param e The dialect specific exception.
* @param errorClass The error class assigned in the case of an unclassified `e`
* @param messageParameters The message parameters of `errorClass`
+ * @param description The error description
* @return `AnalysisException` or its sub-class.
*/
def classifyException(
e: Throwable,
errorClass: String,
- messageParameters: Map[String, String]): AnalysisException = {
- new AnalysisException(errorClass, messageParameters, cause = Some(e))
+ messageParameters: Map[String, String],
+ description: String): AnalysisException = {
+ classifyException(description, e)
Review Comment:
This might be not fully compatible with existing JDBC dialects because values in `messageParameters` has been preprocessed already like quoting, and a JDBC dialect could use regexp for parsing parameters from `mesage`/`description`. Theoretically, it can break the regexps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44449:
URL: https://github.com/apache/spark/pull/44449#discussion_r1444308138
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -633,13 +633,31 @@ abstract class JdbcDialect extends Serializable with Logging {
* @param e The dialect specific exception.
* @param errorClass The error class assigned in the case of an unclassified `e`
* @param messageParameters The message parameters of `errorClass`
+ * @param description The error description
* @return `AnalysisException` or its sub-class.
*/
def classifyException(
e: Throwable,
errorClass: String,
- messageParameters: Map[String, String]): AnalysisException = {
- new AnalysisException(errorClass, messageParameters, cause = Some(e))
+ messageParameters: Map[String, String],
+ description: String): AnalysisException = {
+ classifyException(description, e)
Review Comment:
This might be not fully compatible with existing JDBC dialects because values in `messageParameters` has been preprocessed already like quoting, and a JDBC dialect could use regexp for parsing parameters from `message`/`description`. Theoretically, it can break the regexps.
And if we pass the quoting values to an JDBC dialect, it can throw some Spark exception which performs quoting inside like `PostgresDialect` throws `NonEmptyNamespaceException`. The last one does quoting inside its constructor. Apparently, we will get **double quoting** values which is a bug already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #44449:
URL: https://github.com/apache/spark/pull/44449#discussion_r1444165085
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -633,13 +633,31 @@ abstract class JdbcDialect extends Serializable with Logging {
* @param e The dialect specific exception.
* @param errorClass The error class assigned in the case of an unclassified `e`
* @param messageParameters The message parameters of `errorClass`
+ * @param description The error description
* @return `AnalysisException` or its sub-class.
*/
def classifyException(
e: Throwable,
errorClass: String,
- messageParameters: Map[String, String]): AnalysisException = {
- new AnalysisException(errorClass, messageParameters, cause = Some(e))
+ messageParameters: Map[String, String],
+ description: String): AnalysisException = {
+ classifyException(description, e)
Review Comment:
Instead of passing `description` around, shall we generate the description here using the error class name and the `tableName` in the parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #44449:
URL: https://github.com/apache/spark/pull/44449#discussion_r1444308138
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala:
##########
@@ -633,13 +633,31 @@ abstract class JdbcDialect extends Serializable with Logging {
* @param e The dialect specific exception.
* @param errorClass The error class assigned in the case of an unclassified `e`
* @param messageParameters The message parameters of `errorClass`
+ * @param description The error description
* @return `AnalysisException` or its sub-class.
*/
def classifyException(
e: Throwable,
errorClass: String,
- messageParameters: Map[String, String]): AnalysisException = {
- new AnalysisException(errorClass, messageParameters, cause = Some(e))
+ messageParameters: Map[String, String],
+ description: String): AnalysisException = {
+ classifyException(description, e)
Review Comment:
This might be not fully compatible with existing JDBC dialects because values in `messageParameters` has been preprocessed already like quoting, and a JDBC dialect could use regexp for parsing parameters from `mesage`/`description`. Theoretically, it can break the regexps.
And if we pass the quoting values to an JDBC dialect, it can throw some Spark exception which performs quoting inside like `PostgresDialect` throws `NonEmptyNamespaceException`. The last one does quoting inside its constructor. Apparently, we will get **double quoting** values which is a bug already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46608][SQL] Restore backward compatibility of `JdbcDialect.classifyException` [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #44449:
URL: https://github.com/apache/spark/pull/44449#issuecomment-1881068902
Merging to master. Thank you, @cloud-fan for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org