You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "Quanlong Huang (JIRA)" <ji...@apache.org> on 2018/04/04 23:31:00 UTC

[jira] [Resolved] (ORC-320) C++ writer tests failed when Daylight Saving Time started

     [ https://issues.apache.org/jira/browse/ORC-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Quanlong Huang resolved ORC-320.
--------------------------------
    Resolution: Fixed

Fixed in ORC-322

> C++ writer tests failed when Daylight Saving Time started
> ---------------------------------------------------------
>
>                 Key: ORC-320
>                 URL: https://issues.apache.org/jira/browse/ORC-320
>             Project: ORC
>          Issue Type: Bug
>          Components: C++
>            Reporter: Quanlong Huang
>            Assignee: Quanlong Huang
>            Priority: Major
>
> C++ writer tests failed in writeTimestamp when Daylight Saving Time started. Errors are
> {code:java}
> /mnt/volume1/orc/c++/test/TestWriter.cc:596: Failure
>       Expected: times[i]
>       Which is: 1520762379
> To be equal to: tsBatch->data[i]
>       Which is: 1520765979
> /mnt/volume1/orc/c++/test/TestWriter.cc:596: Failure
>       Expected: times[i]
>       Which is: 1520762319
> To be equal to: tsBatch->data[i]
>       Which is: 1520765919
> /mnt/volume1/orc/c++/test/TestWriter.cc:596: Failure
>       Expected: times[i]
>       Which is: 1520762259
> To be equal to: tsBatch->data[i]
>       Which is: 1520765859
> /mnt/volume1/orc/c++/test/TestWriter.cc:596: Failure
>       Expected: times[i]
>       Which is: 1520762199
> To be equal to: tsBatch->data[i]
>       Which is: 1520765799
> ...
> {code}
> The expected values are 3600 less than the corresponding values.
> This can only be reproduced in American timezones which use Daylight Saving Time. In Asia like China, the test can succeed.
> As time passes by, the test comes back to succeed. It seems that there's something wrong in dealing with timestamps around the Daylight Saving Time switch point. You can increase the rowCount to 102400 to reproduce this failure in American timezones.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)