You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/30 04:37:18 UTC
[GitHub] mistercrunch commented on a change in pull request #6764: Add
feature flag for allowing any column to be filterable or groupable
mistercrunch commented on a change in pull request #6764: Add feature flag for allowing any column to be filterable or groupable
URL: https://github.com/apache/incubator-superset/pull/6764#discussion_r252114119
##########
File path: superset/config.py
##########
@@ -188,7 +188,9 @@
# ---------------------------------------------------
# Feature flags that are on by default go here. Their
# values can be overridden by those in super_config.py
-FEATURE_FLAGS = {}
+FEATURE_FLAGS = {
+ 'ALL_COLS_FILTERABLE_GROUPABLE': False,
Review comment:
I'm not sure how these feature flags are supposed to work in practice in `superset_config`. It appears there's no good way to alter only one of them. You'd have to either alter all of them or none of them. If you were to copy/paste the whole dict to your `superset_config` you'd miss out on new ones as they come, and if you try to import the dict I think you'd run in circular import issue. @xtinec what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org