[GitHub] [ozone] lokeshj1703 commented on a change in pull request #2626: HDDS-5729. support setting maxSizeEnteringTarget and maxSizeLeavingSource in command line

[GitBox <gi...@apache.org>]

lokeshj1703 commented on a change in pull request #2626:
URL: https://github.com/apache/ozone/pull/2626#discussion_r708137550



##########
File path: hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStartSubcommand.java
##########
@@ -54,10 +54,21 @@
           "for 10GB it should be set as 10")
   private Optional<Long> maxSizeToMovePerIterationInGB;
 
+  @Option(names = {"-e", "--maxSizeEnteringTarget"},
+      description = "the maximum size that can enter a target datanode while " +
+          "balancing in GB. This is the sum of data from multiple sources.")
+  private Optional<Long> maxSizeEnteringTarget;
+
+  @Option(names = {"-l", "--maxSizeLeavingSource"},
+      description = "maximum size that can leave a source datanode while " +
+          "balancing in GB, it is the sum of data moving to multiple targets.")
+  private Optional<Long> maxSizeLeavingSource;
+

Review comment:
       NIT: Use InGB suffix similar to maxSizeToMovePerIterationInGB.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org