[GitHub] [hadoop-ozone] GlenGeng commented on a change in pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl

[GitBox <gi...@apache.org>]

GlenGeng commented on a change in pull request #1151:
URL: https://github.com/apache/hadoop-ozone/pull/1151#discussion_r451254135



##########
File path: hadoop-ozone/recon/pom.xml
##########
@@ -108,6 +108,7 @@
             </goals>
             <configuration>
               <arguments>pnpm config set store-dir ~/.pnpm-store</arguments>
+              <npmInheritsProxyConfigFromMaven>false</npmInheritsProxyConfigFromMaven>

Review comment:
       Thanks for pointing out! Will drop this change.

##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java
##########
@@ -78,7 +78,7 @@
       description = "The size of the raft segment used by Apache Ratis on" +
           " SCM. (16 KB by default)"
   )
-  private long raftSegmentSize = 16L * 1024L;
+  private double raftSegmentSize = 16L * 1024L;

Review comment:
       you will see that `ConfigType.SIZE` will be reflected as `StorageUnit`, which need be `double`.
   
   refer to `ConfigurationReflectionUtil`, 
   ```
             case SIZE:
               forcedFieldSet(field, configuration,
                   from.getStorageSize(key, "0B", configAnnotation.sizeUnit()));
               break;
   ```
   
   and `ConfigurationSource`
   ```
     default double getStorageSize(String name, String defaultValue,
         StorageUnit targetUnit)
   ```
   
   This code is not reached before, so merged into HDDS-2823 without breaking CI.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org