You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/04 04:39:58 UTC
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12380: Fix
potential security risk
susiwen8 opened a new pull request #12380: Fix potential security risk
URL: https://github.com/apache/incubator-echarts/pull/12380
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
open new link by 'blank' has security risk
[See this artical](https://dev.to/dhilipkmr/why-should-you-use-noopener-beware-of-security-flaws-3i57)
### Fixed issues
## Details
### Before: What was the problem?
### After: How is it fixed in this PR?
## Usage
### Are there any API changes?
- [ ] The API has been changed.
<!-- LIST THE API CHANGES HERE -->
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on issue #12380: Fix
potential security risk
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #12380: Fix potential security risk
URL: https://github.com/apache/incubator-echarts/pull/12380#issuecomment-608980653
Thanks @susiwen8 ! Can you put the logic of `open` in a helper function module in https://github.com/apache/incubator-echarts/tree/master/src/util ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12380: Fix
potential security risk
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12380: Fix potential security risk
URL: https://github.com/apache/incubator-echarts/pull/12380#issuecomment-610411921
Congratulations! Your PR has been merged. Thanks for your contribution! 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12380: Fix
potential security risk
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #12380: Fix potential security risk
URL: https://github.com/apache/incubator-echarts/pull/12380#issuecomment-608980653
Thanks @susiwen8 ! Can you encapsule the logic of `open` in a helper function module in https://github.com/apache/incubator-echarts/tree/master/src/util ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12380: Fix
potential security risk
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12380: Fix potential security risk
URL: https://github.com/apache/incubator-echarts/pull/12380#issuecomment-608972715
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
The pull request is marked to be `PR: author is committer` because you are a committer of this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12380: Fix
potential security risk
Posted by GitBox <gi...@apache.org>.
pissang merged pull request #12380: Fix potential security risk
URL: https://github.com/apache/incubator-echarts/pull/12380
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org