You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "jojochuang (via GitHub)" <gi...@apache.org> on 2023/10/19 19:00:29 UTC
[PR] Hdds 9384 [ozone]
jojochuang opened a new pull request, #5468:
URL: https://github.com/apache/ozone/pull/5468
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix
1. **Title:** [hsync] Update OpenTelemetry traces in the write path
2. **Description:** Traces for
* Ratis callback function (ContainerStateMachine)
* DataNode PutBlock/WriteChunk
* Client BlockOutputStream WriteChunk
## What is the link to the Apache JIRA
[HDDS-9384](https://issues.apache.org/jira/browse/HDDS-9384)
## How was this patch tested?
Manual test. Screenshots
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #5468:
URL: https://github.com/apache/ozone/pull/5468#issuecomment-2089266214
Attach a few screenshots after the change. It's now able to connect thousands of trace spans.
<img width="973" alt="Screenshot 2024-05-01 at 3 00 40 PM" src="https://github.com/apache/ozone/assets/2691807/50522bfc-c778-4ad3-bb6a-ae81b4810df2">
<img width="899" alt="Screenshot 2024-05-01 at 3 08 19 PM" src="https://github.com/apache/ozone/assets/2691807/67522af7-dadc-4db6-adaf-5f7816b0d182">
<img width="1551" alt="Screenshot 2024-05-01 at 3 45 43 PM" src="https://github.com/apache/ozone/assets/2691807/db704d3a-bb1b-4d2f-9080-6365b428900b">
<img width="1376" alt="Screenshot 2024-05-01 at 4 00 31 PM" src="https://github.com/apache/ozone/assets/2691807/e3e1187c-903c-445a-9e5c-44c585fabb61">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. [hsync] Update OpenTelemetry traces in the write path [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5468:
URL: https://github.com/apache/ozone/pull/5468#issuecomment-1771576008
Maybe the updated PR template is a bit confusing, but "Title" is supposed to be entered only in the title field, not duplicated in the description field.
CC @hemantk-12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. [hsync] Update OpenTelemetry traces in the write path [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on PR #5468:
URL: https://github.com/apache/ozone/pull/5468#issuecomment-1771685810
> Maybe the updated PR template is a bit confusing, but "Title" is supposed to be entered only in the title field, not duplicated in the description field.
>
> CC @hemantk-12
Yeah, I agree. I've also seen couple of PRs with similar duplicated title.
Is there a way to update PR template to fill "Title" field with [this](https://github.com/apache/ozone/blob/f42a2e52db1c100f0700504dcd084c02c86ecbc2/.github/pull_request_template.md?plain=1#L4) instead of commit message? Otherwise we can update the temp to something:
```
1. **Update the Title field:** Title should provide a one sentence overview of the purpose of the PR.
2. **Add Description:**
* What changes are proposed in the PR? and Why? It would be better if it is written from third person's perspective not just for the reviewer.
* Provide as much context and rationale for the pull request as possible. It could be copy-paste from the Jira's description if the jira is well defined.
* If it is complex code, describe the approach used to solve the issue. If possible attach design doc, issue investigation, github discussion, etc.
3. **PR examples:** [PR#3980](https://github.com/apache/ozone/pull/3980), [PR#5265](https://github.com/apache/ozone/pull/5265), [PR#4701](https://github.com/apache/ozone/pull/4701), [PR#5283](https://github.com/apache/ozone/pull/5283), [PR#5300](https://github.com/apache/ozone/pull/5300))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5468:
URL: https://github.com/apache/ozone/pull/5468#issuecomment-2759048008
/pending conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "chungen0126 (via GitHub)" <gi...@apache.org>.
chungen0126 commented on code in PR #5468:
URL: https://github.com/apache/ozone/pull/5468#discussion_r1594022706
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -699,6 +709,8 @@ public boolean delete(Path f, boolean recursive) throws IOException {
private boolean deleteInSpan(Path f, boolean recursive) throws IOException {
incrementCounter(Statistic.INVOCATION_DELETE, 1);
statistics.incrementWriteOps(1);
+ Span span = GlobalTracer.get().activeSpan();
+ span.setTag("path", f.toString());
Review Comment:
Here is also a tag setting the key instead of the path as its value. They should be set the same value for better trace.
https://github.com/apache/ozone/blob/bab281cf0e3b23d4dd3520a06061f7e07ee96ca5/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java#L248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #5468:
URL: https://github.com/apache/ozone/pull/5468#issuecomment-2091319079
@chungen0126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on PR #5468:
URL: https://github.com/apache/ozone/pull/5468#issuecomment-2310911959
<img width="1723" alt="Screenshot 2024-08-26 at 11 00 04 AM" src="https://github.com/user-attachments/assets/46cea4d3-2cfb-4444-b88b-d94612ed55c7">
Rewrote the PR because the block output stream is becoming more asynchronous. Here's the latest screenshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5468: HDDS-9384. Update OpenTelemetry traces in the write path
URL: https://github.com/apache/ozone/pull/5468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5468:
URL: https://github.com/apache/ozone/pull/5468#issuecomment-2814247171
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9384. Update OpenTelemetry traces in the write path [ozone]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #5468:
URL: https://github.com/apache/ozone/pull/5468#discussion_r1594864964
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -699,6 +709,8 @@ public boolean delete(Path f, boolean recursive) throws IOException {
private boolean deleteInSpan(Path f, boolean recursive) throws IOException {
incrementCounter(Statistic.INVOCATION_DELETE, 1);
statistics.incrementWriteOps(1);
+ Span span = GlobalTracer.get().activeSpan();
+ span.setTag("path", f.toString());
Review Comment:
good catch. Updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org