You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/12 08:47:33 UTC

[GitHub] [flink] alibahadirzeybek opened a new pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

alibahadirzeybek opened a new pull request #17456:
URL: https://github.com/apache/flink/pull/17456


   ## What is the purpose of the change
   
   This pull request fixes documentation examples for the kafka producer by replacing the SimpleStringSchema with KafkaSerializationSchema
   
   ## Brief change log
   
     - A new KafkaSerializationSchema is created with basic topic and record content filling
     - A newly created KafkaSerializationSchema is passed as the serialization schema to the FlinkKafkaProducer constructor
   
   ## Verifying this change
   
   This change does not affect any tests since it is an update to the documentation.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980",
       "triggerID" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "124ffefd4430bb8a86db7815280d5f2d1e16b076",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25870",
       "triggerID" : "124ffefd4430bb8a86db7815280d5f2d1e16b076",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b58e63ceb8e0b2fda93214f2884179d2dd692f2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980) 
   * 124ffefd4430bb8a86db7815280d5f2d1e16b076 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25870) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b58e63ceb8e0b2fda93214f2884179d2dd692f2d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980",
       "triggerID" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b58e63ceb8e0b2fda93214f2884179d2dd692f2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940802476


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b58e63ceb8e0b2fda93214f2884179d2dd692f2d (Tue Oct 12 08:49:57 UTC 2021)
   
   **Warnings:**
    * Documentation files were touched, but no `docs/content.zh/` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alibahadirzeybek commented on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
alibahadirzeybek commented on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-958884809






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alibahadirzeybek commented on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
alibahadirzeybek commented on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-958884809


   > LGTM. @alibahadirzeybek Can you rebase this on release-1.13 please?
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980",
       "triggerID" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b58e63ceb8e0b2fda93214f2884179d2dd692f2d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alibahadirzeybek commented on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
alibahadirzeybek commented on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-958884809


   > LGTM. @alibahadirzeybek Can you rebase this on release-1.13 please?
   
   Done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo merged pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
alpinegizmo merged pull request #17456:
URL: https://github.com/apache/flink/pull/17456






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo merged pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
alpinegizmo merged pull request #17456:
URL: https://github.com/apache/flink/pull/17456


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980",
       "triggerID" : "b58e63ceb8e0b2fda93214f2884179d2dd692f2d",
       "triggerType" : "PUSH"
     }, {
       "hash" : "124ffefd4430bb8a86db7815280d5f2d1e16b076",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "124ffefd4430bb8a86db7815280d5f2d1e16b076",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b58e63ceb8e0b2fda93214f2884179d2dd692f2d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24980) 
   * 124ffefd4430bb8a86db7815280d5f2d1e16b076 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17456:
URL: https://github.com/apache/flink/pull/17456#issuecomment-940801890






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] alpinegizmo merged pull request #17456: [FLINK-24509][docs] Add kafka serializer to producer examples

Posted by GitBox <gi...@apache.org>.
alpinegizmo merged pull request #17456:
URL: https://github.com/apache/flink/pull/17456


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org