[GitHub] [trafficcontrol] rawlinp commented on issue #950: [TC-388] Max IP Address in DNS Answer - Default Behavior Change

[GitBox <gi...@apache.org>]

rawlinp commented on issue #950:
URL: https://github.com/apache/trafficcontrol/issues/950#issuecomment-776117919


   Three seems like a reasonable default, but I'd be worried about making "0" now mean 3. The DB actually defaults to 5 currently, which is also somewhat reasonable, but I think we actually write "null" into the DB if the request value is null. If the value is null in the DB, I think we'd have to update the CRConfig generation to set it to 3 (or 5 for consistency), but that would be a change in behavior that might be surprising to users. E.g. maybe they're used to getting the "max" currently and decreasing would break them.
   
   So, I think all we can really do without breaking users would be to set the new default on creates but not updates and add an alert if the chosen value is > 10.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org