You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/06/20 19:17:22 UTC
[GitHub] tinkerpop pull request #638: TINKERPOP-999 Removed generics from ServerGreml...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/638
TINKERPOP-999 Removed generics from ServerGremlinExecutor
https://issues.apache.org/jira/browse/TINKERPOP-999
Pretty simple - I probably could have CTR'd this but since it was a breaking change on 3.3.0 I wanted folks to be more aware of it in case someone was using this class in some way I'm not imagining.
Builds with `mvn clean install -DskipTests && mvn verify -pl gremlin-server -DskipIntegrationTests=false`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/638.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #638
----
commit 4c89e1594537f02c4bb3f0efa60f3e5042621442
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-06-20T19:14:44Z
TINKERPOP-999 Removed generics from ServerGremlinExecutor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #638: TINKERPOP-999 Removed generics from ServerGreml...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/638#discussion_r123119092
--- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java ---
@@ -108,54 +108,24 @@ public GremlinServer(final Settings settings) {
workerGroup = new NioEventLoopGroup(settings.threadPoolWorker, threadFactoryWorker);
}
- serverGremlinExecutor = new ServerGremlinExecutor<>(settings, null, workerGroup, EventLoopGroup.class);
+ serverGremlinExecutor = new ServerGremlinExecutor(settings, null, workerGroup, null);
--- End diff --
Looks like the 4th parameter is no longer needed. Since the PR targets `master/`, it would be fine to remove it altogether, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #638: TINKERPOP-999 Removed generics from ServerGreml...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/638#discussion_r123125481
--- Diff: gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java ---
@@ -108,54 +108,24 @@ public GremlinServer(final Settings settings) {
workerGroup = new NioEventLoopGroup(settings.threadPoolWorker, threadFactoryWorker);
}
- serverGremlinExecutor = new ServerGremlinExecutor<>(settings, null, workerGroup, EventLoopGroup.class);
+ serverGremlinExecutor = new ServerGremlinExecutor(settings, null, workerGroup, null);
--- End diff --
i think you're right. I sorta wonder if the second parameter is of value. Gremlin Server is the only thing that really creates that ExecutorService.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #638: TINKERPOP-999 Removed generics from ServerGremlinExecu...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/638
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #638: TINKERPOP-999 Removed generics from ServerGreml...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---