You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Baoyuantop (via GitHub)" <gi...@apache.org> on 2025/08/15 02:27:51 UTC
[PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Baoyuantop opened a new pull request, #1949:
URL: https://github.com/apache/apisix-website/pull/1949
Changes:
In #1948, I added a lot of redirect rules to avoid 404 ingress doc pages in search engine results. Later, I found that a type of rule was missing. This PR supplemented it.
<!-- Add here what changes were made in this pull request and if possible provide links showcasing the changes. -->
Screenshots of the change:
<!-- Add screenshots depicting the changes. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on code in PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#discussion_r2278237852
##########
.htaccess:
##########
@@ -77,6 +77,8 @@ Redirect 301 "/zh/blog/2021/11/30/use-apisix-ingress-in-kubesphere/httpbin.org/"
Redirect 301 "/zh/blog/2021/08/25/Auth-with-Casbin-in-Apache-APISIX/" "/zh/blog/2021/08/18/auth-with-casbin-in-apache-apisix/"
Redirect 301 "/zh/blog/2022/03/02/apisix-integration-graphql-plugin/" "/zh/blog/2022/03/02/apisix-integration-graphql/"
+RedirectMatch 301 "^/docs/ingress-controller/next/(.*)$" "/docs/ingress-controller/1.8.0/$1"
Review Comment:
`next` directory should point to `2.x` I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on code in PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#discussion_r2281117128
##########
.htaccess:
##########
@@ -77,6 +77,8 @@ Redirect 301 "/zh/blog/2021/11/30/use-apisix-ingress-in-kubesphere/httpbin.org/"
Redirect 301 "/zh/blog/2021/08/25/Auth-with-Casbin-in-Apache-APISIX/" "/zh/blog/2021/08/18/auth-with-casbin-in-apache-apisix/"
Redirect 301 "/zh/blog/2022/03/02/apisix-integration-graphql-plugin/" "/zh/blog/2022/03/02/apisix-integration-graphql/"
+RedirectMatch 301 "^/docs/ingress-controller/next/(.*)$" "/docs/ingress-controller/1.8.0/$1"
Review Comment:
In Docusaurus version management, my understanding is that **Next** refers to the **latest unreleased content**. According to the current PR modification, when users access the **Next** directory, they will be redirected to **version 1.8.x**, which causes a conflict. I can accept this modification by hidding "Next" from the version options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#discussion_r2278310187
##########
.htaccess:
##########
@@ -77,6 +77,8 @@ Redirect 301 "/zh/blog/2021/11/30/use-apisix-ingress-in-kubesphere/httpbin.org/"
Redirect 301 "/zh/blog/2021/08/25/Auth-with-Casbin-in-Apache-APISIX/" "/zh/blog/2021/08/18/auth-with-casbin-in-apache-apisix/"
Redirect 301 "/zh/blog/2022/03/02/apisix-integration-graphql-plugin/" "/zh/blog/2022/03/02/apisix-integration-graphql/"
+RedirectMatch 301 "^/docs/ingress-controller/next/(.*)$" "/docs/ingress-controller/1.8.0/$1"
Review Comment:
The documentation in our previous "next" directory is equivalent to the current documentation in the "1.8.0" directory, with their directories and contents completely matching. If we switch to version 2.x, the document paths for the old and new versions will be significantly different, requiring additional logic to handle these complex relationships, or simply redirecting to the 2.x homepage. Given that each old version document has a tooltip and link to the new version at the top, I think this is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#discussion_r2281162937
##########
.htaccess:
##########
@@ -77,6 +77,8 @@ Redirect 301 "/zh/blog/2021/11/30/use-apisix-ingress-in-kubesphere/httpbin.org/"
Redirect 301 "/zh/blog/2021/08/25/Auth-with-Casbin-in-Apache-APISIX/" "/zh/blog/2021/08/18/auth-with-casbin-in-apache-apisix/"
Redirect 301 "/zh/blog/2022/03/02/apisix-integration-graphql-plugin/" "/zh/blog/2022/03/02/apisix-integration-graphql/"
+RedirectMatch 301 "^/docs/ingress-controller/next/(.*)$" "/docs/ingress-controller/1.8.0/$1"
Review Comment:
I agree with you that the current changes will affect the use of the existing next directory, and for long-term maintenance, preserving the existing next directory is necessary. I would modify the redirection rules to use more fine-grained rules, matching only specific paths rather than the entire next directory. This will increase the number of redirect records, but I think it is acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#issuecomment-3190453597
> May I ask if you have confirmed whether there are any omissions?
The current changes are based on popular paths in Google search. It is not easy for us to add redirects for all 404 pages indexed by Google. If there is expired content later, we can submit it to Google.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect old ingress next version links to new content [apisix-website]
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung merged PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#discussion_r2278715425
##########
.htaccess:
##########
@@ -77,6 +77,8 @@ Redirect 301 "/zh/blog/2021/11/30/use-apisix-ingress-in-kubesphere/httpbin.org/"
Redirect 301 "/zh/blog/2021/08/25/Auth-with-Casbin-in-Apache-APISIX/" "/zh/blog/2021/08/18/auth-with-casbin-in-apache-apisix/"
Redirect 301 "/zh/blog/2022/03/02/apisix-integration-graphql-plugin/" "/zh/blog/2022/03/02/apisix-integration-graphql/"
+RedirectMatch 301 "^/docs/ingress-controller/next/(.*)$" "/docs/ingress-controller/1.8.0/$1"
Review Comment:
Hi @juzhiyuan, please check this when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on code in PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#discussion_r2281187102
##########
.htaccess:
##########
@@ -77,6 +77,8 @@ Redirect 301 "/zh/blog/2021/11/30/use-apisix-ingress-in-kubesphere/httpbin.org/"
Redirect 301 "/zh/blog/2021/08/25/Auth-with-Casbin-in-Apache-APISIX/" "/zh/blog/2021/08/18/auth-with-casbin-in-apache-apisix/"
Redirect 301 "/zh/blog/2022/03/02/apisix-integration-graphql-plugin/" "/zh/blog/2022/03/02/apisix-integration-graphql/"
+RedirectMatch 301 "^/docs/ingress-controller/next/(.*)$" "/docs/ingress-controller/1.8.0/$1"
Review Comment:
Hi @juzhiyuan, I have completed the modification and can check it again. At present, I have found some old broken links with high authority and try to find the matching content in the new version of the document. If there is no matching content, I will jump to the default main page.
@kayx23 If there is new document content, we can gradually remove these rules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: redirect ingress next version links to version 1.8.0 [apisix-website]
Posted by "juzhiyuan (via GitHub)" <gi...@apache.org>.
juzhiyuan commented on code in PR #1949:
URL: https://github.com/apache/apisix-website/pull/1949#discussion_r2281117128
##########
.htaccess:
##########
@@ -77,6 +77,8 @@ Redirect 301 "/zh/blog/2021/11/30/use-apisix-ingress-in-kubesphere/httpbin.org/"
Redirect 301 "/zh/blog/2021/08/25/Auth-with-Casbin-in-Apache-APISIX/" "/zh/blog/2021/08/18/auth-with-casbin-in-apache-apisix/"
Redirect 301 "/zh/blog/2022/03/02/apisix-integration-graphql-plugin/" "/zh/blog/2022/03/02/apisix-integration-graphql/"
+RedirectMatch 301 "^/docs/ingress-controller/next/(.*)$" "/docs/ingress-controller/1.8.0/$1"
Review Comment:
In Docusaurus version management, my understanding is that **Next** refers to the **latest unreleased content**. According to the current PR modification, when users access the **Next** directory, they will be redirected to **version 1.8.x**, which causes a conflict. I can accept this modification by hidding "Next" from the version options. (If @bzp2010 @kayx23 @moonming accept the current modification, then it's okay)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org