[GitHub] [cassandra] adelapena commented on a diff in pull request #2236: CASSANDRA-18037 trunk: Use snake case for the names CQL native functions

["adelapena (via GitHub)" <gi...@apache.org>]

adelapena commented on code in PR #2236:
URL: https://github.com/apache/cassandra/pull/2236#discussion_r1147521788


##########
src/java/org/apache/cassandra/cql3/functions/BytesConversionFcts.java:
##########
@@ -18,92 +18,104 @@
 package org.apache.cassandra.cql3.functions;
 
 import java.nio.ByteBuffer;
-import java.util.HashSet;
 import java.util.List;
-import java.util.Set;
 
 import org.apache.cassandra.cql3.CQL3Type;
-import org.apache.cassandra.db.marshal.AbstractType;
 import org.apache.cassandra.db.marshal.BytesType;
-import org.apache.cassandra.db.marshal.UTF8Type;
-import org.apache.cassandra.transport.ProtocolVersion;
-import org.apache.cassandra.utils.ByteBufferUtil;
 import org.apache.cassandra.exceptions.InvalidRequestException;
 import org.apache.cassandra.serializers.MarshalException;
+import org.apache.cassandra.transport.ProtocolVersion;
+import org.apache.cassandra.utils.ByteBufferUtil;
 
 public abstract class BytesConversionFcts
 {
     public static void addFunctionsTo(NativeFunctions functions)
     {
-        // because text and varchar ends up being synonymous, our automatic makeToBlobFunction doesn't work

Review Comment:
   I have changed the function builders to receive the CQL type, instead of the internal one. That makes the special-casing for {{varchar}} and the {{Set}} unnecessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org