[GitHub] [hadoop] GauthamBanasandra commented on a change in pull request #2051: HDFS-15385 Upgrade boost library

[GitBox <gi...@apache.org>]

GauthamBanasandra commented on a change in pull request #2051:
URL: https://github.com/apache/hadoop/pull/2051#discussion_r453722394



##########
File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/StringUtil.cc
##########
@@ -36,19 +36,19 @@ string StringUtil::ToString(uint32_t v) {
 
 string StringUtil::ToString(int64_t v) {
   char tmp[32];
-  snprintf(tmp, 32, "%"PRId64, v);
+  snprintf(tmp, 32, "%" PRId64, v);
   return tmp;
 }
 
 string StringUtil::ToString(int64_t v, char pad, int64_t len) {
   char tmp[32];
-  snprintf(tmp, 32, "%%%c%"PRId64""PRId64, pad, len);
+  snprintf(tmp, 32, "%%%c%" PRId64 "" PRId64, pad, len);
   return Format(tmp, v);
 }
 
 string StringUtil::ToString(uint64_t v) {
   char tmp[32];
-  snprintf(tmp, 32, "%"PRIu64, v);
+  snprintf(tmp, 32, "%" PRIu64, v);
   return tmp;
 }

Review comment:
       Done @aajisaka. I've removed these.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org