You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2014/10/14 20:02:29 UTC
[GitHub] incubator-brooklyn pull request: Dns entity
GitHub user sjcorbett opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/243
Dns entity
`BindDnsServer` tested on Ubuntu 14.04. Plus other miscellaneous improvements.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/incubator-brooklyn dns-entity
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit c34420a71db18ad5dad4956776b590cec784f6b4
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2014-10-10T16:39:39Z
Adds ScriptHelper.noExtraOutput
commit c933875b6634521dfaef3c95aafd2248e73a1708
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2014-10-10T16:42:42Z
BindDnsServer tested on Ubuntu
commit aaf1782221329181f31f4adca9b27e445fc9df80
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2014-10-14T18:00:53Z
Documentation and other tidies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Dns entity
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/243#discussion_r18889705
--- Diff: usage/jsgui/src/main/webapp/assets/js/util/brooklyn-utils.js ---
@@ -140,15 +140,19 @@ define([
* alternate message if parsing fails or the parsed object has no message.
* @param {jqXHR} xhrResponse
* @param {string} alternateMessage
- * @param {string} logMessage, if false or null, does not log;
- * otherwise it logs a message and the xhrResponse, with logMessage (or with alternateMessage if logMessage is true)
+ * @param {string=} logMessage if false or null, does not log;
--- End diff --
Is the `=` deliberate here? Looks like a typo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Dns entity
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/243#discussion_r18889507
--- Diff: software/network/src/main/java/brooklyn/entity/network/bind/BindDnsServerImpl.java ---
@@ -63,7 +63,7 @@
private static final Logger LOG = LoggerFactory.getLogger(BindDnsServerImpl.class);
private AtomicLong serial = new AtomicLong(System.currentTimeMillis());
- private Object[] mutex = new Object[0];
+ private final Object[] mutex = new Object[0];
--- End diff --
Personal preference: use `new Object()` for mutex. Only reason to use array is if it needs to be serializable, but an entity should never be serialized directly.
But that wasn't your code...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Dns entity
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/243#issuecomment-59197466
@sjcorbett looks really good! Merging.
For the record, I believe you're working on some more live tests with a real domain name we own for test purposes. That will be in future PRs though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Dns entity
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/243#discussion_r18889861
--- Diff: usage/jsgui/src/main/webapp/assets/js/util/brooklyn-utils.js ---
@@ -140,15 +140,19 @@ define([
* alternate message if parsing fails or the parsed object has no message.
* @param {jqXHR} xhrResponse
* @param {string} alternateMessage
- * @param {string} logMessage, if false or null, does not log;
- * otherwise it logs a message and the xhrResponse, with logMessage (or with alternateMessage if logMessage is true)
+ * @param {string=} logMessage if false or null, does not log;
--- End diff --
@sjcorbett has confirmed that the `=` indicates it is an optional argument. So this is deliberate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Dns entity
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---