You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2013/10/05 00:51:52 UTC

Review Request 14500: HIVE-5449: Hive schematool info option incorrectly reports error for Postgres metastore

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14500/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-5449
    https://issues.apache.org/jira/browse/HIVE-5449


Repository: hive-git


Description
-------

The schema tool has an option to verify the schema version stored in the metastore. This is implemented as a simple select query executed via JDBC. The problem is that Postgres requires object names to be quoted due to the way tables are created. It's a similar issues hit by metastore direct SQL (HIVE-5264, HIVE-5265 etc).
The patch is to use quoted identifiers when required.


Diffs
-----

  beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java 23e2fc7 
  beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java a1f9a6a 

Diff: https://reviews.apache.org/r/14500/diff/


Testing
-------

Manually tested with postgres metastore


Thanks,

Prasad Mujumdar