You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "lvanneo (via GitHub)" <gi...@apache.org> on 2023/03/22 02:27:49 UTC

[GitHub] [inlong] lvanneo opened a new pull request, #7665: [INLONG-7658][Manager] Optimized table index

lvanneo opened a new pull request, #7665:
URL: https://github.com/apache/inlong/pull/7665

   ### Prepare a Pull Request
   - Fixes #7658
   
   ### Motivation
   
   *Database tables have redundant indexes, which improves write performance.*
   
   ### Modifications
   
   *Delete redundant indexes for tables inlong_stream_ext, inlong_stream, inlong_group_ext.*
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #7665: [INLONG-7658][Manager] Optimized table index

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7665:
URL: https://github.com/apache/inlong/pull/7665


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7665: [INLONG-7658][Manager] Optimized table index

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7665:
URL: https://github.com/apache/inlong/pull/7665#discussion_r1144324425


##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -75,8 +75,7 @@ CREATE TABLE IF NOT EXISTS `inlong_group_ext`
     `is_deleted`      int(11)           DEFAULT '0' COMMENT 'Whether to delete, 0: not deleted, > 0: deleted',
     `modify_time`     timestamp    NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'Modify time',
     PRIMARY KEY (`id`),
-    UNIQUE KEY `unique_inlong_group_key` (`inlong_group_id`, `key_name`),
-    INDEX `group_ext_group_index` (`inlong_group_id`)
+    UNIQUE KEY `unique_inlong_group_key` (`inlong_group_id`, `key_name`)

Review Comment:
   Please change the `manager-test/src/main/resources/h2/apache_inlong_manager.sql` at the same time, thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] fuweng11 commented on pull request #7665: [INLONG-7658][Manager] Optimized table index

Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on PR #7665:
URL: https://github.com/apache/inlong/pull/7665#issuecomment-1478838759

   Please also modify` apache_inlong_manager.sql` in `manager-test`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] lvanneo commented on a diff in pull request #7665: [INLONG-7658][Manager] Optimized table index

Posted by "lvanneo (via GitHub)" <gi...@apache.org>.
lvanneo commented on code in PR #7665:
URL: https://github.com/apache/inlong/pull/7665#discussion_r1148738371


##########
inlong-manager/manager-web/sql/apache_inlong_manager.sql:
##########
@@ -75,8 +75,7 @@ CREATE TABLE IF NOT EXISTS `inlong_group_ext`
     `is_deleted`      int(11)           DEFAULT '0' COMMENT 'Whether to delete, 0: not deleted, > 0: deleted',
     `modify_time`     timestamp    NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP COMMENT 'Modify time',
     PRIMARY KEY (`id`),
-    UNIQUE KEY `unique_inlong_group_key` (`inlong_group_id`, `key_name`),
-    INDEX `group_ext_group_index` (`inlong_group_id`)
+    UNIQUE KEY `unique_inlong_group_key` (`inlong_group_id`, `key_name`)

Review Comment:
   > Please change the `manager-test/src/main/resources/h2/apache_inlong_manager.sql` at the same time, thanks.
   
   ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang commented on pull request #7665: [INLONG-7658][Manager] Optimized table index

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on PR #7665:
URL: https://github.com/apache/inlong/pull/7665#issuecomment-1484736662

   1.6.0 has been released, please create a new update file for the coming 1.7.0 based on 1.6.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] fuweng11 commented on a diff in pull request #7665: [INLONG-7658][Manager] Optimized table index

Posted by "fuweng11 (via GitHub)" <gi...@apache.org>.
fuweng11 commented on code in PR #7665:
URL: https://github.com/apache/inlong/pull/7665#discussion_r1148746390


##########
inlong-manager/manager-web/sql/changes-1.6.0.sql:
##########
@@ -91,3 +91,9 @@ VALUES ('audit_sdk_collect', 'SDK', 0, '1'),
        ('audit_sort_mysql_output', 'MYSQL', 1, '24'),
        ('audit_sort_kudu_input', 'KUDU', 0, '25'),
        ('audit_sort_kudu_output', 'KUDU', 1, '26');
+
+DROP INDEX `group_ext_group_index` ON `inlong_group_ext`;
+DROP INDEX `stream_id_index` ON `inlong_stream_ext`;
+DROP INDEX `stream_group_id_index` ON `inlong_stream`;
+DROP INDEX `unique_inlong_stream` ON `inlong_stream`;

Review Comment:
   Are the following statements redundant?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org