[GitHub] [cloudstack] ustcweizhou opened a new pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)

[GitBox <gi...@apache.org>]

ustcweizhou opened a new pull request #3639: Multiple networks support for vms in advanced zone with security group (and kvm support)
URL: https://github.com/apache/cloudstack/pull/3639
 
 
   ## Description
   
   <!--- Describe your changes in detail -->
   
   In advanced zone with security groups, there can be multiple shared networks with security groups enabled. However, it is only possible to create vm with only one network. When we try to create vm with multiple networks, it gives error "Only support one network per VM if security group enabled".
   
   Operations succeed if we create a vm with one network and add other networks to the vm. However, the new nics do not work as there are no network rules for them applied on hypervisor.
   
   This PR will enable the functionality on KVM hypervisors, including the support on
   (1) API to support vm with multiple networks for KVM
   (2) UI to create vm with multiple networks for KVM
   (3) network rules applied on all nics (when create a vm, and add/remove nics)
   (4) network rules for all secondary ips on all nics
   
   This PR includes the other two bug fixes: #3635 and #3636 
   This PR also included a script file for integration test.
   
   Fixes: #3045 #3568 
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [X] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   environment:
   ubuntu 18.04 / python2
   advanced zone with security groups
   
   check network rules for vm (eg i-10-20-VM)
   - ipset list i-10-20-VM
   - ipset list i-10-20-VM-6
   - iptables-save | grep i-10-20
   - ebtables-save | grep i-10-20
   
   vm actions:
   - create a vm with multiple networks
   - add new nic to vm
   - remove nic from vm
   - add secondary ips to vm
   - remove secondary ips to vm
   - reboot vm
   - migrate vm
   - stop vm
   - start vm
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services